-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Tinkerboard 2 #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Let's rename TINKER_BOARD2
to TINKER_BOARD_2
and tinker-board2
to tinker-board-2
, and give the README sections that mention Tinker Board an update, e.g. by adding a sentence below the Tinker Board code example: "For Tinker Board 2, use BoardType.TINKER_BOARD_2
."
Thanks Linus, I have made the changes. Let me know what you think. |
🚀 |
Thanks Linus! |
I'll release this in a new version later today, will let you know. :) |
By the way, |
Done! https://pypi.org/project/rpi-backlight/2.3.0
I suppose if there's a reliable way to detect the board type, we could have automatic detection if no board type is explicitly provided - perhaps by checking the existence of each path in |
I was thinking of using
What is the output on the Pi? |
Hi Linus, been a while. Hope all is well.
I have recently purchased a Tinkerboard 2 and am adding support for it.
I'd like you to check over the changes and make sure its implemented how youd like. If not, I am happy to make any changes.