Python 3 & GTK3 port (combined & rebased) #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your SoBs are missing. Commits already have some, so please add yours as well. |
Reformat the test/* and se/test/* scripts using the following command: $ autopep8 --in-place --aggressive test/* se/test/* Signed-off-by: Mark Greer <mgreer@animalcreek.com> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
Python2 is deprecated so convert the neard test scripts in the 'test' and 'se/test' directories to Python3. Signed-off-by: Mark Greer <mgreer@animalcreek.com> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
GTK 2 has reached its end of life so convert the GUIs in 'test' directory to GTK 3. Signed-off-by: André Apitzsch <git@apitzsch.eu> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
|
Done! |
|
Yay, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially just a simple rebase of the branch
mag/python3-izeand #13 together targeting master branch.I've tried this for a bit on my msm8974-oneplus-one and as far as the scripts are concerned I didn't see any issue while testing, so I don't see a reason not to merge this. If there's any hidden problems with them, we can fix them later? @krzk
Fixes #3