Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 & GTK3 port (combined & rebased) #25

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

z3ntu
Copy link

@z3ntu z3ntu commented Jun 18, 2024

This is essentially just a simple rebase of the branch mag/python3-ize and #13 together targeting master branch.

I've tried this for a bit on my msm8974-oneplus-one and as far as the scripts are concerned I didn't see any issue while testing, so I don't see a reason not to merge this. If there's any hidden problems with them, we can fix them later? @krzk

Fixes #3

@krzk
Copy link
Collaborator

krzk commented Jun 24, 2024

Your SoBs are missing. Commits already have some, so please add yours as well.

mgreeraz and others added 3 commits June 24, 2024 09:39
Reformat the test/* and se/test/* scripts using the following command:

	$ autopep8 --in-place --aggressive test/* se/test/*

Signed-off-by: Mark Greer <mgreer@animalcreek.com>
Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
Python2 is deprecated so convert the neard test scripts in the 'test'
and 'se/test' directories to Python3.

Signed-off-by: Mark Greer <mgreer@animalcreek.com>
Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
GTK 2 has reached its end of life so convert the GUIs in 'test'
directory to GTK 3.

Signed-off-by: André Apitzsch <git@apitzsch.eu>
Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
@z3ntu
Copy link
Author

z3ntu commented Jun 24, 2024

Done!

@krzk krzk merged commit 17b8110 into linux-nfc:master Jun 24, 2024
120 of 132 checks passed
@z3ntu
Copy link
Author

z3ntu commented Jun 24, 2024

Yay, thanks!

@z3ntu z3ntu deleted the py3-again branch June 24, 2024 08:42
@krzk krzk mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to Python3
3 participants