types: Fix PMRWBM register name #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
reviewed
Apr 30, 2024
| @@ -584,7 +603,7 @@ enum nvme_pmrcap { | |||
| #define NVME_PMRCAP_WDS(pmrcap) NVME_GET(pmrcap, PMRCAP_WDS) | |||
| #define NVME_PMRCAP_BIR(pmrcap) NVME_GET(pmrcap, PMRCAP_BIR) | |||
| #define NVME_PMRCAP_PMRTU(pmrcap) NVME_GET(pmrcap, PMRCAP_PMRTU) | |||
| #define NVME_PMRCAP_PMRWMB(pmrcap) NVME_GET(pmrcap, PMRCAP_PMRWMB) | |||
| #define NVME_PMRCAP_PMRWBM(pmrcap) NVME_GET(pmrcap, PMRCAP_PMRWBM) | |||
There was a problem hiding this comment.
Maybe keep a compat around to avoid unnecessary incompatibility?
There was a problem hiding this comment.
Changed the patch to remain the current definitions also as deprecated. Thank you.
Incorrectly defined as PMRWMB. Also add enum nvme_pmrcap documentation. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
pmrcap-pmrwbm
branch
from
50c9549
to
e6a8174
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrectly defined as PMRWMB.
Also add enum nvme_pmrcap documentation.