nvme: allocate aligned payloads for all nvme commands #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nvme_alloc has already a built in check which version of the allocation strategy should be used based on the len argument. There is no need for fw_download to do this as well. Signed-off-by: Daniel Wagner <dwagner@suse.de>
These two function are abstracting the libhugebtl API. Let's rename Rename these functions because we want to introduce a generic alloc function with alignment support. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Introduce a cleanup helper function to free generic memory allocation from malloc, calloc, etc. Signed-off-by: Daniel Wagner <dwagner@suse.de>
The kernel supports since v5.2 direct mapped DMA buffers to userspace. Up to this point a bounce buffer was involved. Because the buffers are now directly accessed by the device, the rules of alignment also apply for the payloads. Introduce a helper to allocate all correctly buffers aligned. Furthermore, ensure that the buffer is a multiple of 4k, because there are devices on the market which will always transfer a multiple of 4k, even if we ask for less, e.g 512 bytes. This avoid stack smashes. Signed-off-by: Daniel Wagner <dwagner@suse.de>
igaw
force-pushed
the
fix-alloc
branch
4 times, most recently
from
11f3426
to
372cdf9
Compare
The kernel supports since v5.2 direct mapped DMA buffers to userspace. Up to this point a bounce buffer was involved. Because the buffers are now directly accessed by the device, the rules of alignment also apply for the payloads. Use the newly introduced nvme_alloc helper to allocate correctly aligned payloads for all nvme commands. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Use the cleanup infra structure to free the nvme_dev resource. This allows us to use return directly and makes the code a bit more readable. While at it also do the same for trivial filedescriptor cases. The more complex cases such in submit_io() needs a bit more tinkering to get right. Signed-off-by: Daniel Wagner <dwagner@suse.de>
|
I've added a cleanup patch on top for the |
This was referenced Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel supports since v5.2 direct mapped DMA buffers to userspace.
Up to this point a bounce buffer was involved. Because the buffers are
now directly accessed by the device, the rules of alignment also apply
for the payloads.
Furthermore, ensure that the buffer is a multiple of 4k, because there
are devices on the market which will always transfer a multiple of 4k,
even if we ask for less, e.g 512 bytes. This avoid stack smashes.
Fixes: #linux-nvme/libnvme#684