Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wildcard package installation not working with dnf module #161

Merged

Conversation

richm
Copy link
Contributor

@richm richm commented Jun 14, 2024

Cause: The dnf module is not installing cockpit-*

Consequence: The full list of requested packages is not installed.

Fix: Call the dnf command directly with the wildcard package name
and the packages to exclude.

Result: The requested wildcard packages are installed.

spetrosi
spetrosi previously approved these changes Jun 14, 2024
@spetrosi
Copy link
Collaborator

[citest]

2 similar comments
@richm
Copy link
Contributor Author

richm commented Jun 14, 2024

[citest]

@ukulekek
Copy link

[citest]

Cause: The dnf module is not installing cockpit-*

Consequence: The full list of requested packages is not installed.

Fix: Call the dnf command directly with the wildcard package name
and the packages to exclude.

Result: The requested wildcard packages are installed.

This also adds a check to the test to ensure the excluded
packages are not installed.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm force-pushed the use-dnf-cmd-for-wildcard-install branch from 746bff1 to ae44043 Compare June 17, 2024 16:11
@richm richm changed the title use dnf cmd for wildcard install fix: wildcard package installation not working with dnf module Jun 17, 2024
@richm
Copy link
Contributor Author

richm commented Jun 17, 2024

[citest]

@richm richm merged commit 19fdfff into linux-system-roles:main Jun 17, 2024
18 of 21 checks passed
@richm richm deleted the use-dnf-cmd-for-wildcard-install branch June 17, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants