Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new context key JobOwnerID #162

Merged
merged 2 commits into from
May 15, 2023

Conversation

allaouiamine
Copy link
Contributor

Adding a new context key JobOwnerID, which may be used by some plugins to store the owner of the job

…gs to store the owner of the job

Signed-off-by: Amine Allaoui <aamine@meta.com>
pkg/types/types.go Outdated Show resolved Hide resolved
@mimir-d
Copy link
Member

mimir-d commented May 15, 2023

i know this isnt in scope of the PR, but could you have a quick look at those test failures as well?

Co-authored-by: mimir-d <mimir-d@users.noreply.github.com>
Signed-off-by: Amine Allaoui <aamine@meta.com>
@mimir-d
Copy link
Member

mimir-d commented May 15, 2023

merging, thanks very much

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (2831239) 63.13% compared to head (0ca6f21) 63.10%.

❗ Current head 0ca6f21 differs from pull request most recent head 88c5d0a. Consider uploading reports for the commit 88c5d0a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   63.13%   63.10%   -0.04%     
==========================================
  Files         165      165              
  Lines       10468    10473       +5     
==========================================
  Hits         6609     6609              
- Misses       3121     3126       +5     
  Partials      738      738              
Flag Coverage Δ
e2e 48.44% <0.00%> (-0.04%) ⬇️
integration 54.14% <0.00%> (-0.03%) ⬇️
unittests 49.51% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/types.go 66.66% <0.00%> (-33.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mimir-d mimir-d merged commit 4d6d981 into linuxboot:main May 15, 2023
@allaouiamine allaouiamine deleted the adding-job-owner-key branch May 15, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants