Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repack visitor #225

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Repack visitor #225

merged 1 commit into from
Nov 9, 2018

Conversation

GanShun
Copy link
Member

@GanShun GanShun commented Nov 9, 2018

This allows us to repack a per file compressed FV into a new nested
compressed FV

Signed-off-by: Gan Shun Lim ganshun@gmail.com

@GanShun
Copy link
Member Author

GanShun commented Nov 9, 2018

This has one terrible test, but it works for now.

@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #225 into master will increase coverage by 1.14%.
The diff coverage is 38.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   31.94%   33.08%   +1.14%     
==========================================
  Files          37       37              
  Lines        2113     2155      +42     
==========================================
+ Hits          675      713      +38     
+ Misses       1318     1316       -2     
- Partials      120      126       +6
Impacted Files Coverage Δ
pkg/uefi/section.go 23.71% <0%> (-4.11%) ⬇️
pkg/visitors/repack.go 46.78% <46.78%> (ø)
pkg/visitors/find.go 48.52% <0%> (-3.53%) ⬇️
pkg/visitors/remove.go 48.71% <0%> (-2.4%) ⬇️
pkg/visitors/dxecleaner.go
pkg/visitors/assemble.go 46.28% <0%> (+15.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71386cf...018c663. Read the comment docs.

rjoleary
rjoleary previously approved these changes Nov 9, 2018
pkg/uefi/section.go Outdated Show resolved Hide resolved
pkg/uefi/section.go Outdated Show resolved Hide resolved
pkg/uefi/section.go Outdated Show resolved Hide resolved
This allows us to repack a per file compressed FV into a new nested
compressed FV

Signed-off-by: Gan Shun Lim <ganshun@gmail.com>
@GanShun GanShun merged commit bd0624b into linuxboot:master Nov 9, 2018
@GanShun GanShun deleted the repack-pr branch November 9, 2018 18:50
@GanShun GanShun mentioned this pull request Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants