-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T430 build does not boot #667
Comments
@flawedworld : GPG_TTY temporary fix is in master now (until #665 is permanently fixed so that value to /dev/console is not hardcoded anymore) |
@flawedworld I flashed a build off of #656. I'd expect to get an error message about GPG, but I don't get any graphics output at all. |
@nickfrostatx Are you using a T430 with Nvidia GPU or only the iGPU? |
@nickfrostatx Please update us after trying the latest commits in #656 |
@nickfrostatx #656 is merged. Please tag me here if you still experience the same issue. |
@tlaurion I'm not sure if @nickfrostatx ever figured it out, but I have tried to flash to the t430 multiple times and it always ends up with no video output after the reboot. Steps:
The laptop seems to reboot but there is no video output after this point at all. (Tried MiniDP) I've attached the images I built in case there of any use. |
@openfinesse |
Intel |
@openfinesse can you try again but instead of typing in reboot you just hold down power then turn on again? I am going to check hashes in a second please give me a mo. |
Building cleanly @ commit 78053b9 with make BOARD=t430 produces a SHA256 of coreboot.rom being: Your SHA256 of the coreboot.rom in the attached zip file is: You may wish to try another system or try with a clean tree. |
Adding on to that, building cleanly @ commit 78053b9 with make BOARD=t430-flash produces a SHA256 of t430-flash.rom being: Your SHA256 of t430-flash.rom in the attached zip is: |
First off I would like to say that I am a relatively new user so please excuse the mistakes that I will probably make. I am flashing to a x230 and having the exact same issue as @openfinesse. Steps:
I end up with a blank screen, but the light for the power button turns on and off as expected. Attached is the coreboot.rom file. I will try to do a clean build at commit 78053b9. |
I will do a clean build when I can, but I am currently having problems with #733. |
Kernel is not reproducible. So hash wont be the same until #571 is fixed. |
Reopening issue |
Let me know which tickets to close and which to let open, a lot exist for t430. |
I think the issue title "T430 build does not boot" (adjust for X230 if applicable) is a better fit, since I don't think this is a video issue. |
Alright, I re-cloned the git and built Is there any new information I could provide or new strategies I could try. I could post images of me running |
@flawedworld is latest commit working for you? (nothing changed related to t430 per se) |
@lsafd : i'm confused. You are talking about x230 and not t430? Please open another issue. On x230-flash being flashed, that should be as easy as doing: |
Sorry I didn't understand I will open another issue. Should I delete my previous comments as they were all related to the x230? (I wrote my steps above that was one of them and I am still having troubles) |
They have really common base, but this issue is linked to @openfinesse / @nickfrostatx issue which is a T430 not booting (with potential screen issue) that I think non-relevent since #656 got merged. Please let us know so we can close still opened t430 issue if non-relevant anymore. (I do not own that model, please tag t430 owners from #691 ) |
@flawedworld @lsafd @SebastianMcMillan @openfinesse @nickfrostatx @MrChromebox I did a quick review of the following facts:
We are interested in the following line: What we could do here is take some of the #307 (the IFD) and put it in blobs, considering that ifd was unlocked and ME was neutered and outputted:
So 0001afff - 00003000 = 17FFF (decimal: 98303) Meaning that the original region:
has became:
So we passed from Which we SHOULD pass to the BIOS region:
Which we remember was hex: I made the error of replacing 70000 to 80000 in x230-hotp-verification based on considered working t430 coreboot config. This doesn't seem to be valid. Reconsidering what to do from here for the x230-hotp-verification platform, which doesn't compile if we go back to CBFS_REGION of 70000, not having enough space:
Important notes:
Solution:
|
Works on commit 78053b9 for me, I am using fully stripped out and shrunk ME |
@flawedworld : so without libremkey-hotp-verification support. Seems like we are just lucky and don't use the CBFS_REGION fully. |
I got a t430 to play with a few weeks ago, and ran into the same issue. 9719510 is the first revision which works for me, though it seems it's not a fully clean build - I've only removed the t430 folder, and got a working image. I've since removed everything in build, which results in an image with a different checksum, and a black screen when flashed. So far I haven't been able to get a working image with a clean build. |
@TrapAcid @flawedworld @lsafd @SebastianMcMillan : What is the right CBFS_REGION to be in master? We seem to not move forward on this which creates duplicates like #815. |
I would not be the right person to ask about this since I don't have a
T430. However, it should be using an identical config as the X230, so
cross-reference to the X230 config.
…On Mon, Aug 31, 2020, 10:12 tlaurion ***@***.***> wrote:
@TrapAcid <https://github.com/Trapacid> @flawedworld
<https://github.com/flawedworld> @lsafd <https://github.com/lsafd>
@SebastianMcMillan <https://github.com/SebastianMcMillan> : What is the
right CBFS_REGION to be in master?
Is
https://github.com/osresearch/heads-wiki/blob/master/Clean-the-ME-firmware.md
followed?
We seem to not move forward on this which creates duplicated like #815
<#815>.
Board owners, please follow up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#667 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFNTUNGYBB3K2HLQR57JMNDSDO4VHANCNFSM4KNQLI2Q>
.
|
I've tried the same CBFS_REGION setting as for x230 when debugging the black screen. I have no idea what made the one I currently use boot - but it wasnt the CBFS size change. |
I've tried to follow https://github.com/corna/me_cleaner/wiki/External-flashing on shrinking the regions, but I don't know what to do with the shrunken ME and IFD bin files besides putting them in heads/build/coreboot-4.8.1/3rdparty/blobs/mainboard/lenovo/t430 and running make BOARD=t430 and t430-flash in heads directory. Tried flashing that coreboot.rom from build/t430 internally and just gave a black screen after reboot. Running me_cleaner to shrink the compiled coreboot.rom prints some python error about 'entries' not being defined and running me_cleaner on the regular ME blobs from the original 12mb dump prints the same thing. CBFS size in t430 config is 0x800000 while size in x230 is in 0x700000. And just in case, my T430 does not have an NVIDIA card. update: reached out to @flawedworld again and told me what I need to actually do. Going to try this again, but following directions this time. |
@TrapAcid CBFS should be equal as in x230 so 710000 and me cleaner instructions from heads-wiki should be applied on 8MB spi flash dump and reflashed. Any improvement on doc and t430 PR should follow please. Will edit with references |
Instructions for testing here: #815 (comment) |
Fixed |
I tried twice to flash Heads onto a T430.
x230
config built off of masterTHINKPAD_T430
instead of x230: https://github.com/nickfrostatx/heads/compare/ac71f295a..f2039a74In both cases, it never gives any screen output, just a black screen. I left it on for 30 minutes or so, and still no output.
x230-flash boots just fine. I think I'm only using the upper 4MB of the 12MB ROM image by using
--ifd --image bios
. Maybe that's where I'm going wrong?The steps I followed (in case I've been doing it wrong):
x230-flash.rom
to the chipcoreboot.rom
that I built frommake BOARD=x230
mount-usb
flashrom --force --noverify-all --programmer internal:laptop=force_I_want_a_brick --ifd --image bios /media/coreboot.rom
The text was updated successfully, but these errors were encountered: