T430 build does not boot #667

slashnick · 2020-01-30T05:56:34Z

I tried twice to flash Heads onto a T430.

Once using the x230 config built off of master
Once with a modified config where I told coreboot my board was THINKPAD_T430 instead of x230: https://github.com/nickfrostatx/heads/compare/ac71f295a..f2039a74

In both cases, it never gives any screen output, just a black screen. I left it on for 30 minutes or so, and still no output.

x230-flash boots just fine. I think I'm only using the upper 4MB of the 12MB ROM image by using --ifd --image bios. Maybe that's where I'm going wrong?

The steps I followed (in case I've been doing it wrong):

Attach a chip clip to the 4MB BIOS chip
Write x230-flash.rom to the chip
Plug in a flash drive with the 12MB coreboot.rom that I built from make BOARD=x230
Boot the machine
mount-usb
flashrom --force --noverify-all --programmer internal:laptop=force_I_want_a_brick --ifd --image bios /media/coreboot.rom
Reboot (I didn't set up GPG keys or the TPM or anything)

The text was updated successfully, but these errors were encountered:

flawedworld · 2020-01-30T09:52:48Z

Please see #656 and #580 . The port is done pretty much, we need to just fix GPG issues which are due to upstream it seems.

tlaurion · 2020-01-30T16:25:59Z

@flawedworld : GPG_TTY temporary fix is in master now (until #665 is permanently fixed so that value to /dev/console is not hardcoded anymore)

slashnick · 2020-01-30T18:09:08Z

@flawedworld I flashed a build off of #656. I'd expect to get an error message about GPG, but I don't get any graphics output at all.

flawedworld · 2020-01-31T19:35:41Z

@nickfrostatx Are you using a T430 with Nvidia GPU or only the iGPU?

flawedworld · 2020-05-15T17:13:29Z

@nickfrostatx Please update us after trying the latest commits in #656

tlaurion · 2020-05-20T04:04:32Z

@nickfrostatx #656 is merged. Please tag me here if you still experience the same issue.

openfinesse · 2020-05-31T04:30:33Z

@tlaurion I'm not sure if @nickfrostatx ever figured it out, but I have tried to flash to the t430 multiple times and it always ends up with no video output after the reboot.

Steps:

Externally flash 8MB unlocked and me cleaned image.
Flash t430-flash.rom image to the 4MB chip
Boot to heads shell, mount usb, and add GPG key to 12MB image.
Flash 12MB coreboot.rom image (from /build/t430/). Flash shows VERIFIED
Reboot with "reboot" command.

The laptop seems to reboot but there is no video output after this point at all. (Tried MiniDP)

I've attached the images I built in case there of any use.
t430-images.zip
Please let me know if I should be doing something differently.

snmcmillan · 2020-05-31T21:20:59Z

@openfinesse
Do you have an Intel or nvidia model?

openfinesse · 2020-05-31T21:24:33Z

Intel

flawedworld · 2020-05-31T21:30:44Z

@openfinesse can you try again but instead of typing in reboot you just hold down power then turn on again? I am going to check hashes in a second please give me a mo.

flawedworld · 2020-05-31T22:36:24Z

Building cleanly @ commit 78053b9 with make BOARD=t430 produces a SHA256 of coreboot.rom being:
fc79e3de048865d52897ddf2a718df550c9ab42d88280d3cce6d7edfd3da2670

Your SHA256 of the coreboot.rom in the attached zip file is:
f7361916361e2619348fb37dd0dafba451df507887fca3efb159a20841f6b715

You may wish to try another system or try with a clean tree.

flawedworld · 2020-05-31T22:45:55Z

Adding on to that, building cleanly @ commit 78053b9 with make BOARD=t430-flash produces a SHA256 of t430-flash.rom being:
1a607dc2c0e3ef1a081c3da02e043bf6eff3ac50c2a808467887cd15d94eeb6b

Your SHA256 of t430-flash.rom in the attached zip is:
909e2f5cbd84573630d01f3c0a77acb79393ee84f9172a39b2e2b578295378d1

lsafd · 2020-06-01T02:15:07Z

First off I would like to say that I am a relatively new user so please excuse the mistakes that I will probably make.

I am flashing to a x230 and having the exact same issue as @openfinesse.

Steps:

Flash x230-flash.rom image to the 4MB chip.
Externally flash 8MB unlocked and me cleaned image.
Boot to heads shell, run "mount-usb".
Run "flash.sh -c /media/coreboot.rom" to flash the 12MB coreboot.rom image (from /build/x230-hotp-verification/).
Run "reboot" to reboot.

I end up with a blank screen, but the light for the power button turns on and off as expected. Attached is the coreboot.rom file.

rom_file.zip

I will try to do a clean build at commit 78053b9.

flawedworld · 2020-06-03T16:32:32Z

@lsafd Your coreboot.rom file has a SHA256 of:
2a5877ed2909b4660b8f74a78821f40afa6cafb0186f68672fec7a83cf210ba3

Building at 78053b9 produces:
84ed5c262d78eb14fa5ae8bf44acd6e670852b3e0b2ddf062864e76a1aecc8e5

Try on a clean tree or another system.

lsafd · 2020-06-03T16:59:44Z

I will do a clean build when I can, but I am currently having problems with #733.

tlaurion · 2020-06-03T18:45:22Z

@flawedworld

Building cleanly @ commit 78053b9 with make BOARD=t430 produces a SHA256 of coreboot.rom being:
fc79e3de048865d52897ddf2a718df550c9ab42d88280d3cce6d7edfd3da2670

Your SHA256 of the coreboot.rom in the attached zip file is:
f7361916361e2619348fb37dd0dafba451df507887fca3efb159a20841f6b715

You may wish to try another system or try with a clean tree.

Kernel is not reproducible. So hash wont be the same until #571 is fixed.

tlaurion · 2020-06-03T18:45:38Z

@lsafd : #733 is fixed

tlaurion · 2020-06-03T18:46:41Z

Reopening issue

tlaurion · 2020-06-03T18:47:19Z

Let me know which tickets to close and which to let open, a lot exist for t430.

snmcmillan · 2020-06-03T19:42:24Z

I think the issue title "T430 build does not boot" (adjust for X230 if applicable) is a better fit, since I don't think this is a video issue.

lsafd · 2020-06-03T20:48:13Z

Alright, I re-cloned the git and built x230-hotp-verification again. The resulting coreboot.rom file has the exact same sha256.

Is there any new information I could provide or new strategies I could try. I could post images of me running flash.sh if that would help. I am just unsure where to go from here.

tlaurion · 2020-06-03T21:24:32Z

@flawedworld is latest commit working for you? (nothing changed related to t430 per se)

tlaurion · 2020-06-03T21:33:58Z

Alright, I re-cloned the git and built x230-hotp-verification again. The resulting coreboot.rom file has the exact same sha256.

Is there any new information I could provide or new strategies I could try. I could post images of me running flash.sh if that would help. I am just unsure where to go from here.

@lsafd : i'm confused. You are talking about x230 and not t430? Please open another issue.

On x230-flash being flashed, that should be as easy as doing:
Run "flash.sh -c /media/coreboot.rom" to flash the 12MB coreboot.rom image (from /build/x230-hotp-verification/).

lsafd · 2020-06-03T21:35:29Z

Sorry I didn't understand I will open another issue. Should I delete my previous comments as they were all related to the x230? (I wrote my steps above that was one of them and I am still having troubles)

tlaurion · 2020-06-03T21:36:58Z

They have really common base, but this issue is linked to @openfinesse / @nickfrostatx issue which is a T430 not booting (with potential screen issue) that I think non-relevent since #656 got merged.

Please let us know so we can close still opened t430 issue if non-relevant anymore. (I do not own that model, please tag t430 owners from #691 )

tlaurion · 2020-06-04T16:39:31Z

@flawedworld @lsafd @SebastianMcMillan @openfinesse @nickfrostatx @MrChromebox

I did a quick review of the following facts:

xx30 (t430, x230 and others, x230 tested only here) have the following space available for BIOS region in IFD per output of ifdtool -x bottom.rom extracted from original bottom SPI chip, initially upgraded to latest BIOS version (2.75 for x230):

Found Region Section
FLREG0:    0x00000000
  Flash Region 0 (Flash Descriptor): 00000000 - 00000fff 
FLREG1:    0x0bff0500
  Flash Region 1 (BIOS): 00500000 - 00bfffff 
FLREG2:    0x04ff0003
  Flash Region 2 (Intel ME): 00003000 - 004fffff
FLREG3:    0x00020001
  Flash Region 3 (GbE): 00001000 - 00002fff 
FLREG4:    0x00001fff
  Flash Region 4 (Platform Data): 00fff000 - 00000fff (unused)

We are interested in the following line:
Flash Region 1 (BIOS): 00500000 - 00bfffff
so 00bfffff - 00500000 = 6FFFFF (70000, which was the correct value of initial x230 board, while I do not understand why and how t430 could have a 80000 value. This seems to be the reason of the no screen output aka no boot from coreboot (or brick)

What we could do here is take some of the #307 (the IFD) and put it in blobs, considering that ifd was unlocked and ME was neutered and outputted:

The ME region can be reduced up to:
 00003000:0001afff me

So 0001afff - 00003000 = 17FFF (decimal: 98303)

Meaning that the original region:

FLREG2:    0x04ff0003
  Flash Region 2 (Intel ME): 00003000 - 004fffff

has became:

FLREG2:    0x04ff0003
  Flash Region 2 (Intel ME): 00003000 - 0001afff

So we passed from
004fffff - 00003000 = 4FCFFF (dec: 5230591)
to dec: 98303
so gained 5230591 - 98303 = 5132288

Which we SHOULD pass to the BIOS region:

FLREG1:    0x0bff0500
  Flash Region 1 (BIOS): 00500000 - 00bfffff

Which we remember was hex: 70000
to Dec: 7340032 + 5132288 = 12472320
To hex: BE5000 (MAXIMAL THEORETIC CBFS REGION VALUE IN COREBOOT CONFIG FOR FULLY NEUTERED ME)

I made the error of replacing 70000 to 80000 in x230-hotp-verification based on considered working t430 coreboot config. This doesn't seem to be valid.

Reconsidering what to do from here for the x230-hotp-verification platform, which doesn't compile if we go back to CBFS_REGION of 70000, not having enough space:

x230-hotp-verification/util/cbfstool/cbfstool x230-hotp-verification/coreboot.pre.tmp add-payload -f ../../build/x230-hotp-verification/bzImage -n fallback/payload  -c none  -r COREBOOT   -C "intel_iommu=igfx_off quiet" -I "../../build/x230-hotp-verification/initrd.cpio.xz"
E: Could not add [../../build/x230-hotp-verification/bzImage, 7001540 bytes (6837 KB)@0x0]; too big?
E: Failed to add '../../build/x230-hotp-verification/bzImage' into ROM image.
E: Failed while operating on 'COREBOOT' region!
E: The image will be left unmodified.
make[1]: *** [Makefile.inc:920: x230-hotp-verification/coreboot.pre] Error 1
make[1]: Leaving directory '/root/project/build/coreboot-4.8.1'
make: *** [Makefile:382: /root/project/build/coreboot-4.8.1/x230-hotp-verification/.build] Error 1

Src

Important notes:

We cannot change the CBFS_REGION and make it larger alone (bigger BIOS) without having IFD regions adapted so that ME region smaller and freed space being given to the BIOS region. Providing IFD.bin alone could resolve that.
When calling flash.sh, we are actually asking flashrom to take the image.rom and flash the BIOS region out of it.
Consequently, it seems that flashrom doesn't validate that there is enough space and just overwrites what is there in SPI flash, resulting in a non-booting machine.

Solution:

We could have generic flash script (common to xx30) flash both Flash Descriptor and BIOS regions from prepared xx30 images.
Since those IFD regions are aligned, this means that flashed IFD should probably become:
- Flash Region 1 (BIOS): 00500000 - 0001b000
- Flash Region 2 (Intel ME): 00003000 - 0001afff
But that means that ME will need to be neutered and flashed externally prior of flashing the BIOS region and IFD over unlocked IFD.

flawedworld · 2020-06-04T21:30:57Z

@flawedworld is latest commit working for you? (nothing changed related to t430 per se)

Works on commit 78053b9 for me, I am using fully stripped out and shrunk ME

tlaurion · 2020-06-05T14:49:29Z

@flawedworld is latest commit working for you? (nothing changed related to t430 per se)

Works on commit 78053b9 for me, I am using fully stripped out and shrunk ME

@flawedworld : so without libremkey-hotp-verification support. Seems like we are just lucky and don't use the CBFS_REGION fully.

bwachter · 2020-07-17T12:41:53Z

I got a t430 to play with a few weeks ago, and ran into the same issue. 9719510 is the first revision which works for me, though it seems it's not a fully clean build - I've only removed the t430 folder, and got a working image.

I've since removed everything in build, which results in an image with a different checksum, and a black screen when flashed. So far I haven't been able to get a working image with a clean build.

tlaurion · 2020-08-31T15:12:03Z

@TrapAcid @flawedworld @lsafd @SebastianMcMillan : What is the right CBFS_REGION to be in master?
Is https://github.com/osresearch/heads-wiki/blob/master/Clean-the-ME-firmware.md followed?

We seem to not move forward on this which creates duplicates like #815.
Board owners, please follow up.

snmcmillan · 2020-08-31T15:22:49Z

I would not be the right person to ask about this since I don't have a T430. However, it should be using an identical config as the X230, so cross-reference to the X230 config.

…

On Mon, Aug 31, 2020, 10:12 tlaurion ***@***.***> wrote: @TrapAcid <https://github.com/Trapacid> @flawedworld <https://github.com/flawedworld> @lsafd <https://github.com/lsafd> @SebastianMcMillan <https://github.com/SebastianMcMillan> : What is the right CBFS_REGION to be in master? Is https://github.com/osresearch/heads-wiki/blob/master/Clean-the-ME-firmware.md followed? We seem to not move forward on this which creates duplicated like #815 <#815>. Board owners, please follow up. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#667 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFNTUNGYBB3K2HLQR57JMNDSDO4VHANCNFSM4KNQLI2Q> .

bwachter · 2020-08-31T17:21:53Z

I've tried the same CBFS_REGION setting as for x230 when debugging the black screen. I have no idea what made the one I currently use boot - but it wasnt the CBFS size change.

ghost · 2020-08-31T19:19:53Z

I've tried to follow https://github.com/corna/me_cleaner/wiki/External-flashing on shrinking the regions, but I don't know what to do with the shrunken ME and IFD bin files besides putting them in heads/build/coreboot-4.8.1/3rdparty/blobs/mainboard/lenovo/t430 and running make BOARD=t430 and t430-flash in heads directory.

Tried flashing that coreboot.rom from build/t430 internally and just gave a black screen after reboot.

Running me_cleaner to shrink the compiled coreboot.rom prints some python error about 'entries' not being defined and running me_cleaner on the regular ME blobs from the original 12mb dump prints the same thing.

CBFS size in t430 config is 0x800000 while size in x230 is in 0x700000.

And just in case, my T430 does not have an NVIDIA card.

update: reached out to @flawedworld again and told me what I need to actually do. Going to try this again, but following directions this time.

tlaurion · 2020-08-31T22:17:43Z

@TrapAcid CBFS should be equal as in x230 so 710000 and me cleaner instructions from heads-wiki should be applied on 8MB spi flash dump and reflashed.

Any improvement on doc and t430 PR should follow please.

Will edit with references

tlaurion · 2020-09-01T13:10:42Z

Instructions for testing here: #815 (comment)

…s to fix linuxboot#815 and linuxboot#667

tlaurion · 2020-09-02T21:26:55Z

Fixed

tlaurion closed this as completed May 20, 2020

tlaurion reopened this Jun 3, 2020

lsafd mentioned this issue Jun 3, 2020

Blank Screen After Internally Flashing x230-hotp-verification #737

Closed

ghost mentioned this issue Aug 29, 2020

Blank screen after internal T430 build flash #815

Closed

tlaurion changed the title ~~No screen output after flashing to a T430~~ T430 build does not boot Aug 31, 2020

tlaurion added a commit to tlaurion/heads that referenced this issue Sep 1, 2020

xx30 boards: fixing CONFIG_CBFS_SIZE=0x710000 for x230 and t430 board…

cde6e24

…s to fix linuxboot#815 and linuxboot#667

tlaurion mentioned this issue Sep 1, 2020

xx30 boards: fixing CONFIG_CBFS_SIZE=0x710000 for x230 and t430 boards #821

Merged

tlaurion closed this as completed Sep 2, 2020

This was referenced Sep 19, 2020

X230 suspend #608

Closed

x230-hotp-verification: not waking from suspend #770

Closed

xx30 boards: suspend/resume fix #838

Merged

tlaurion mentioned this issue Oct 28, 2020

x220, add GPG key to running Bios and reflash not working #870

Closed

This was referenced Nov 9, 2020

t430 no boot #897

Closed

Platform blobs, collaborators/maintainers/testers for faster problems resolution #692

Open

T430 build does not boot #667

T430 build does not boot #667

Comments

slashnick commented Jan 30, 2020 • edited Loading

flawedworld commented Jan 30, 2020

tlaurion commented Jan 30, 2020 • edited Loading

slashnick commented Jan 30, 2020

flawedworld commented Jan 31, 2020

flawedworld commented May 15, 2020

tlaurion commented May 20, 2020

openfinesse commented May 31, 2020 • edited Loading

snmcmillan commented May 31, 2020

openfinesse commented May 31, 2020

flawedworld commented May 31, 2020 • edited Loading

flawedworld commented May 31, 2020

flawedworld commented May 31, 2020

lsafd commented Jun 1, 2020 • edited Loading

flawedworld commented Jun 3, 2020

lsafd commented Jun 3, 2020

tlaurion commented Jun 3, 2020 • edited Loading

tlaurion commented Jun 3, 2020

tlaurion commented Jun 3, 2020

tlaurion commented Jun 3, 2020

snmcmillan commented Jun 3, 2020

lsafd commented Jun 3, 2020

tlaurion commented Jun 3, 2020 • edited Loading

tlaurion commented Jun 3, 2020 • edited Loading

lsafd commented Jun 3, 2020 • edited Loading

tlaurion commented Jun 3, 2020 • edited Loading

tlaurion commented Jun 4, 2020 • edited Loading

flawedworld commented Jun 4, 2020

tlaurion commented Jun 5, 2020 • edited Loading

bwachter commented Jul 17, 2020

tlaurion commented Aug 31, 2020 • edited Loading

snmcmillan commented Aug 31, 2020 via email

bwachter commented Aug 31, 2020

ghost commented Aug 31, 2020 • edited by ghost Loading

tlaurion commented Aug 31, 2020 • edited Loading

tlaurion commented Sep 1, 2020

tlaurion commented Sep 2, 2020

slashnick commented Jan 30, 2020 •

edited

Loading

tlaurion commented Jan 30, 2020 •

edited

Loading

openfinesse commented May 31, 2020 •

edited

Loading

flawedworld commented May 31, 2020 •

edited

Loading

lsafd commented Jun 1, 2020 •

edited

Loading

tlaurion commented Jun 3, 2020 •

edited

Loading

tlaurion commented Jun 3, 2020 •

edited

Loading

tlaurion commented Jun 3, 2020 •

edited

Loading

lsafd commented Jun 3, 2020 •

edited

Loading

tlaurion commented Jun 3, 2020 •

edited

Loading

tlaurion commented Jun 4, 2020 •

edited

Loading

tlaurion commented Jun 5, 2020 •

edited

Loading

tlaurion commented Aug 31, 2020 •

edited

Loading

ghost commented Aug 31, 2020 •

edited by ghost

Loading

tlaurion commented Aug 31, 2020 •

edited

Loading