-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xx30 boards: suspend/resume fix #838
xx30 boards: suspend/resume fix #838
Conversation
@tlaurion I'll add it. |
Decided to generalize the concept, since this problem SHOULD affect all boards that have the same IFD map not matching BIOS region (where from #692 listed board tester: |
@Thrilleratplay what platforms do you have? I see you are not listed under #692 ? |
@Thrilleratplay So you have a T430. Is it suffering from suspend/resume issue with coreboot config specifying |
Ci failing for coreboot 4.12 not downloading.... Retrying until it passes. |
@tlaurion It is a device I use mostly for checking standard coreboot configs when updating coreboot-builder-scripts and uses |
@Thrilleratplay : I will then consequently clone the x230 coreboot config and define the board with same coreboot base. It would not make any sense that it works. Just a false negative from lack of response from board users, based on this post. That region cannot be larger then CONFIG_CBFS_SIZE=0x700000 if IFD is not resized from liberated ME neutered and freed space, which is another debate and should be another board config, unless #703 is generalized, for which we don't have consensus yet. |
TODO: cherry pick Nitrokey@ad75d8e, extend and comment linking to #667 (comment) Will fix #770 |
Oups..... needs rebase on master
|
…" by disabling board "CONFIG_DROPBEAR=y" and "CONFIG_LINUX_E1000E" to save space per @alex-nitrokey test under linuxboot#770 to fix linuxboot#608
…30 boards and coreboot configs as a result of testing those 2 boards against supend/resume fix
…ed suspend/resume issues.
99ea5a2
to
caff212
Compare
I confirm the fix for x230 and x230-hotp-verification. @flawedworld, please test master when you have a second (artifacts from CIs are downloadable through the little green checkmark beside each commit) |
As explained here (@Thrilleratplay that NEEDS to be documented in development section/board porting...), CBFS region needs to be consistent to what is really available in IFD.
The suspend resume issues reported #770 #608, and blank screen upon internal flashing reported #737 were linked to CBFS mismatches. Thanks to @alex-nitrokey to have tested #770 (comment), since changing CBFS region a while ago caused this regression.
Drops:
Adds: