test: add tests for RollingFileAppender test #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests for two overloaded setDatePattern() and it will test internal computeRollOverTime() Log: add RollingFileAppender tests for two constructors setDatePattern()
the Weekly and Monthly Rollover will change its date, it's different with 'now' by design. The original assertion didn't notice this. This fix make unit test pass. Log: remove wrong assertion in RollingFileAppender
|
Doc Check bot |
|
Please resolve all conflicts, and better check whether we have accepted your advice. |
这个提交已经过去半年了，有什么问题也应该在当时解决。不可能再去重新搭建环境，测试，解决冲突，没有考虑的必要了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit
Add REAL
RollingFileAppendertest for the two overloaded functions, the original test is just some getter setter tests, which are really useless.This is just a part of
RollingFileAppendertest, I will supplement more later.The second commit
There's a wrong assertion, it shouldn't exist by design. It hinders the unit test. Fix it to make test pass.