Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jagged edges on ddciicon #242

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: jagged edges on ddciicon #242

merged 1 commit into from
Jun 20, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jun 19, 2024

Use smooth scaling before drawing to smaller QImage

Issue: linuxdeepin/developer-center#8691

Use smooth scaling before drawing to smaller QImage

Issue: linuxdeepin/developer-center#8691
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jun 19, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#242
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • DDciIconPrivate::paint函数中,对layer图像进行了缩放操作,但没有检查缩放后的图像是否仍然符合原始图像的宽高比。
  • 缩放操作使用了Qt::KeepAspectRatioQt::SmoothTransformation,这可能会导致图像质量降低,特别是当缩放比例不合适时。

是否建议立即修改:

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit da27fb7 into linuxdeepin:master Jun 20, 2024
19 of 21 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Jun 25, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants