Support metaldata metadata provider #3593
Conversation
The AWS connection strategy relies on making a magic address routable, which is fine in a cloud env where that is the norm, but is not fine in a hardware based environment where it may not be practical to add arbitrary magic addresses. Since this commit is in sync with linuxkit/linuxkit#3593 it also breaks compat with the AWS API.
|
This is ok. Is there any way to add tests to this? |
|
Given that none of the other providers presently have tests, is there a mechanism you'd prefer to set the precedent with? Spinning up a server inside of the test is a non-starter since it expects the server on port 80, but it might be possible to fake out the http.Client. |
|
I guess I really cannot complain, then, can I? |
|
I will build and push out the signed packages; is this ready from your perspective? |
|
I'd like to let it sit till the end of the week. I'm reasonably satisfied with it, but I want to make sure there aren't any major corner cases I haven't accounted for yet. |
|
OK, post here when ready and I will push them out. |
|
@deitch this has been running for a few days now and I'm relatively satisfied that there's no major corner cases in it. Feel free to merge and push out packages at your leisure. |
|
Needs a rebase, and then I can push the images out and kick off CI |
the-maldridge
force-pushed
the
metaldata
branch
from
0e01a2f
to
99e3826
Compare
|
Pushed out and signed. Please update the hashes with |
Signed-off-by: Michael Aldridge <aldridge.mac@gmail.com>
|
Done. |
the-maldridge
force-pushed
the
metaldata
branch
from
99e3826
to
b820b0a
Compare
Signed-off-by: Michael Aldridge aldridge.mac@gmail.com
- What I did
I added a new metadata provider that supports the metaldata API provided by ResinStack MetalData. This provider uses a DNS name which greatly simplifies the network topology by allowing the remote network to resolve a DNS name, optionally after canonicalizing it against a search domain.
- How I did it
I copied components of existing providers (AWS and Vultr) and modifying them to suit the API handled by MetalData.
- How to verify it
Get a metaldata server spun up (or don't, the API can be satisfied with a carefully laid out folder structure on disk) and configure your DNS to handle a request for 'metaldata' to point back to wherever this webserver is. Once you've done this you can boot a machine and observe that the metaldata probe succeeds and information is summoned.
- Description for the changelog
Support MetalData metadata source.