Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peazip-add-to-archive@xszabo3: update install instructions #464

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

xszabo3
Copy link
Contributor

@xszabo3 xszabo3 commented Aug 13, 2024

Removed the pictures, if someone knows how to make them work on the Cinnamon Spices website please let me know.
Included steps how to place the missing icons into the correct folder. Is there no way of doing it automatically if the user downloads it from their system?

I was wondering if the name should be updated again. It seems extremely long compared to the other actions on the site.
I was thinking of [actionname] action for Peazip(Flatpak).

@rcalixte
Copy link
Member

Removed the pictures, if someone knows how to make them work on the Cinnamon Spices website please let me know.

Take a look at other Spices. In its simplest form, you can probably use the hyperlink to the GitHub URL at this repository so that they will always be in sync.

Is there no way of doing it automatically if the user downloads it from their system?

Which icons are you referring to? You can configure the Icon in the Nemo Action file.

I was wondering if the name should be updated again.

Feel free. It's just the metadata. Once you get it right, it will be easy enough to repeat for the consecutive Actions.

@rcalixte rcalixte merged commit c942be9 into linuxmint:master Aug 13, 2024
1 check passed
@xszabo3
Copy link
Contributor Author

xszabo3 commented Aug 13, 2024

Thank you @rcalixte ! I will add back the pictures.

The action file needs an icon which is specified with Icon-Name= . The flatpak app didn't install any as a theme icon, and it needs a theme icon according to the sample action. The missing icon is solved after dropping the icon in the ~/.local/share/icons folder. So this is only a problem in the case of custom icons.

@rcalixte
Copy link
Member

The flatpak app didn't install any as a theme icon

It ships icons but the path is probably in the Flatpak path. Check for something under /var/lib/flatpak/exports/share/icons. You can consider creating a symlink and pointing the Icon-Name property to that path. That is much more sustainable long-term in case the icon changes upstream. Test with that locally to make sure that it works.

@xszabo3
Copy link
Contributor Author

xszabo3 commented Aug 13, 2024

The symlink works, thanks again @rcalixte ! The user still needs to move it to the icons folder, but this is definietly a better solution...

@rcalixte
Copy link
Member

The user still needs to move it to the icons folder, but this is definietly a better solution...

Not at all actually. You can include the symlink. Just make sure it points to an absolute path. Symlinks are just files that are special pointers elsewhere. It should work like that. 😅

@rcalixte
Copy link
Member

Hmm. It might not actually be a supported parameter for Icon-Name... This is a hypothesis. I haven't tested it. (On a personal note, this is why I haven't personally created any Actions for Flatpak applications since they can be a bit tricky.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants