Skip to content

Commit

Permalink
gtkdoc: remove dependencies on custom target files (#10606)
Browse files Browse the repository at this point in the history
Sadly, the `dependencies` kwarg does not actually do what it seems to be
trying to be used for, here. It is for listing dependency or library
objects whose compiler flags should be added to gtkdoc-scangobj.

It will not actually add ninja target dependencies. The similar kwarg in
other meson functions (e.g. genmarshal and compile_schemas) that *do*
allow adding target dependencies, is `depend_files`.

Older versions of meson simply did nothing in an if/elif/elif block
where these custom_targets never matched anything, and were thus
silently ignored.

Meson 0.61 type-validates the arguments and rejects CustomTarget as
invalid:

```
docs/reference/cinnamon-js/meson.build:11:6: ERROR: gnome.gtkdoc keyword argument 'dependencies' was of type array[CustomTarget] but should have been array[Dependency | SharedLibrary | StaticLibrary]
```
  • Loading branch information
eli-schwartz authored Feb 3, 2022
1 parent 3244a47 commit 9ccce54
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion docs/reference/cinnamon-js/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ gnome.gtkdoc(
'cinnamon-js',
mode: 'xml',
main_xml: 'cinnamon-js-docs.sgml',
dependencies: parts_files,
src_dir: meson.current_build_dir(),
install: true,
)

0 comments on commit 9ccce54

Please sign in to comment.