Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When will cjs be based on mozjs91? #102

Closed
LeosDing opened this issue May 7, 2022 · 7 comments
Closed

When will cjs be based on mozjs91? #102

LeosDing opened this issue May 7, 2022 · 7 comments

Comments

@LeosDing
Copy link

LeosDing commented May 7, 2022

When will cjs be based on mozjs91? Based on mozjs78 already two years ago.

@LeosDing
Copy link
Author

LeosDing commented May 7, 2022

How different is cjs and gjs? I replaced cjs with gjs when compiling cinnamon, and the compilation passed.
New version of gjs using mozjs91.

@Fantu
Copy link
Contributor

Fantu commented Jun 9, 2022

usually the transition to a new version of mozjs also requires changes in cinnamon and in the applets
using gjs instead of cjs is possible, need also adding a patch with the necessary changes on cinnamon but I think it is to avoid, would risk creating unexpected events with the applets (due to any changed functions), not to mention that every new version of gjs used by the distro should be kept updated and tested
the better is cjs rebase so cinnamon and applets will be adapted to new version

@diizzyy
Copy link

diizzyy commented Jul 15, 2022

mozjs78 also seems to have reached end of life upstream, https://www.mozilla.org/en-US/firefox/78.15.0/releasenotes/

@mtwebster
Copy link
Member

Didn't have time to do it prior to our current release, hopefully in the coming months.

This isn't as urgent as it may appear - we use it for language bindings only, but we'll get to it.

@bgermann
Copy link

How about skipping 91 and depending on 102 instead?

@jbicha
Copy link

jbicha commented Aug 31, 2022

I do encourage you to use mozjs102 instead. That will get you about a year of Mozilla support from now, while mozjs91 is going out of support now.

You can include mozjs102 in the same repos you use to offer new Cinnamon builds.

@Fantu
Copy link
Contributor

Fantu commented Jan 22, 2023

mtwebster started to prepare a rebase with new gjs that use mozjs102: #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants