object.cpp: Defer processing an object, rather than crash, when a toggle unref is already queued. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toggle unref is already queued. This prioritizes the originally queued toggle direction. Fixes linuxmint/cinnamon#9916 at least until: linuxmint#96
|
This is the upstream fix for this: https://gitlab.gnome.org/GNOME/gjs/-/merge_requests/593 Well the fix for this issue and for a lot of bugs more... |
This don't fix 
|
Yes I wanted to backport all of that and managed to get it to build: #96 but we're really missing higher glib and gobject-introspection versions, and even though it builds, it causes way more problems than it fixes for us on 20.04/lm 20. Once we get to a new base, this fix can be removed and we'll up our version safely. For now, this prevents the crashes we've had reported and seems to have little to no side effects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prioritizes the originally queued toggle direction.
Fixes linuxmint/cinnamon#9916
at least until:
#96