[WIP] renaming files by two times clicking on them[final version]

[arnaghizadeh]

Adds the feature which was discussed in #520 , here is a video preview http://youtu.be/J9ogU80dwr0

[simonzack]

Thank you so much for this, this is absolutely a necessary feature. I hope this gets merged soon.

[simonzack]

It's been some months now, can somebody take a look at this again? I think this is feature is quite important for many people.

[simonzack]

@mtwebster bump.

[mtwebster]

Hi, sorry for taking so long to look at this - I'd like to include it for 2.6. A few issues though:

• I think that if I first click the icon of a file, then click the text, that should count as a second click, and induce renaming. Right now, if I select the icon, I then have to click the text twice to rename.
• It seems like it doesn't matter when I do the second click, it'll always rename - even 5 minutes later - is this intentional?
• Can you rebase this PR against the current nemo master? (If you don't know how, let me know and I can give you step-by-step)
• Can you implement this in the list view also (same as icon view, only when over actual text)
• Can you do a little bit of code cleanup to make it consistent to itself and the rest of nemo:
  • Use spaces, not tabs (4)
  • Put spaces between all operators and around function parameters - for example, if (nemo_view_get_foo (view) == view->bar) { }
  • don't put comments after a { - just place the comment before that block of code

Let me know if I'm not making any sense - thanks!

[ghost]

waiting for this important feature for months now
(could be switchable in the config - so no one would be disadvantaged if someone doesn't want it)

[arnaghizadeh]

hey guys, sorry I got a little busy, I will clean the code in may.

@mtwebster
1- Agreed, this makes more sense. I will fix it up
2- Yeah it is intentional. It is the same as windows, it is working just fine for years on windows I didn't see any reason to change it. However, making a limited time makes sense too. I'm neutral on this one, if you think it would make more sense I can put some kind of limit on it. like 100 times the time of double click or something similar. If users wait more than this time they have to click two times again instead of one.
3- yup I will, I will try to find a way myself.
4- hmmm.. doesn't work on list view? didn't know that, lets see what I can do(this may be a little challenging as I don't know what the problem is now).
5- yup, I will keep those in mind.

[kevlogan90]

@AlirezaNaghizadeh have you had time to work on this code? This is something I would like to have added to nemo.

[arnaghizadeh]

I cleaned up the code, the final version is pushed with another pull request (see #913)!
@mtwebster the problem with List View is not related to this code! The code uses "nemo_icon_canvas_item_get_icon_rectangle" and "nemo_icon_canvas_item_get_text_rectangle" as standard functions to get the dimensions of texts and icons! These functions are applicable in Compact View and Icon View but do not work in List View mode. This seems to be a bug in the code which is another problem altogether. I think you guys should fix these two functions to work in List View as well. Because it is a minor issue and unrelated to this topic I have pushed it as it is.