Fix desktop redraws in GTK 3.21.3 and later

[lukefromdc]

GTK 3.21.3 and later broke desktop redrawing except in Nautilus. The commit that made the difference between it working and not working was traced to
GNOME/nautilus@6d6bf1e
canvas-container: don't force native window for the desktop canvas
shortly before Nautilus 3.7.21 came out. To make this work on Nemo also required forcing the scrolledwindow of nemo-desktop-icon-view transparent with a cssprovider, as otherwise it would put a white background on the desktop. Works, running it right now as I post this.

Fixes #1231

[itzexor]

Tagging mate-desktop/caja#575 and #1231 so that those people can test this if they want.

Edit: If you include "Fixes #1231" in your PR note, it should close that issue once it's merged.

[mtwebster]

Hi,

Can you try putting the css in this file: https://github.com/linuxmint/nemo/blob/master/src/nemo-style-application.css - it gets loaded during nemo startup, and would be cleaner than how it is here.

I'll try to test this weekend as well. Thanks

[lukefromdc]

I just tried that, it only worked in Adwaita because all other themes I have override
the css file and put their background on the desktop. With the cssprovider themes
are overridden.

On 7/22/2016 at 12:03 AM, "Michael Webster" notifications@github.com wrote:

Hi,

Can you try putting the css in this file:
https://github.com/linuxmint/nemo/blob/master/src/nemo-style-
application.css - it gets loaded during nemo startup, and would be
cleaner than how it is here.

I'll try to test this weekend as well. Thanks

---

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1232 (comment)

[leigh123linux]

@lukefromdc

this works for some themes, the patch still needs some work

[lukefromdc]

You found a problem the GNOME developers had a lot of trouble with in later Nautilus work: both the notebook and both paned widgets pick up default background colors in many but not all themes. Only my own theme and Adwaita work either with my original PR or with your patch version(which also works). The offending widgets are both paned widgets and the notebook. The notebook can be turned transparent in nemo-style-application.css but both paned widgets get it overridden by the theme and show the theme background color. I could fix that but would be using gtk_widget_set_name or adding a style class to them. A quick test with the set_css_name code gave a build failure after I used it wrong in some way.

[lukefromdc]

I'll try this later today (Monday) I was out of town all day today

On 7/23/2016 at 8:05 AM, "leigh123linux" notifications@github.com wrote:

I've altered the css in the patch to try and address the themes
issues, I've tested with mate-themes and arc themes and they seem
to work.

[canvas-
container.patch.txt](https://github.com/linuxmint/nemo/files/379531
/canvas-container.patch.txt)

---

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#1232 (comment)

[lukefromdc]

I just tested your latest patch, all the MATE themes still drew their background colors on the desktop. Adwaita, Raleigh, and my own UbuntuStudio_Legacy theme all worked. Troublesome widgets were the notebook and paned widgets. Editing the css file got it to work in every theme I have, though I found out the hard way that I had to run "make clean" between every test or the gresource based on this file would not be regenerated (ugh). The patch below resulted:

--- /home/luke/Desktop/nemo-style-application.css   2016-07-26 00:16:35.497198233 -0400
+++ /home/luke/Desktop/nemo-style-application.css_FIXED 2016-07-26 00:54:24.208289398 -0400
@@ -1,7 +1,10 @@
 /* Desktop text stuff */

 .nemo-desktop-icon-view,
-.nemo-desktop-icon-view .view {
+.nemo-desktop-icon-view .view,
+.nemo-window-pane,
+.nemo-desktop-window paned,
+.nemo-desktop-window notebook{
     background-color: transparent;
 }

[lukefromdc]

Closing in favor of #1235 which uses a better approach to the same job and is what I now use myself

[lukefromdc]

Closing in favor of #1235 which uses a better approach to the same job and is what I now use myself