Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update gtk_ui.py #31

Closed
wants to merge 1 commit into from
Closed

Conversation

DirkHaar
Copy link

Make the installer gtk_ui window resizable to allow more overview on multi-drive/multi-partition machines.

Make the installer gtk_ui window resizable to allow more overview on multi-drive/multi-partition machines.
@DirkHaar
Copy link
Author

I have no idea how to test that! Would somebody show me where to find a manual or a how-to guide?

@clefebvre
Copy link
Member

in a live session, you would edit the file directly and run the installer.

@clefebvre
Copy link
Member

I'll mark your PR as WIP for now.

@clefebvre clefebvre changed the title Update gtk_ui.py [WIP] Update gtk_ui.py Apr 20, 2017
@DirkHaar
Copy link
Author

DirkHaar commented May 8, 2017

Thanks Clem, I was wasn't able to figure out how to do a test, even with some support via irc.

@clefebvre
Copy link
Member

I'm going to close it for now, but I'll give you a few hints in case you want to get this working:

Once in the session you can "locate gtk_ui.py" and edit it as root to test the installer.

If you make the window resizable, you're creating two regressions...

First, you'll need to change the position of the main window (in ubiquity.ui) from center-always to center.

Second, you'll need to force it to become non-resizable and set back its dimension when it comes to showing the slideshow.

@clefebvre clefebvre closed this May 17, 2017
@DirkHaar DirkHaar deleted the patch-1 branch February 19, 2018 20:49
@DirkHaar
Copy link
Author

Hi clem,
after being bothered with that issue again while installing last week I tested this by simply replacing
self.live_installer.set_resizable(False)
into
self.live_installer.set_resizable(True)
in the source.
(You have to start and abort the install to do that, otherwise you don't have an editable version, as gtk_ui.py is on a ro fs only before first start! That's why I wasn't able to figure out how to change that last year - still learning.)

The result is what I expected (see attached screenshot).

ubiquity_fullscreen_partition_edit

The window keeps it size first while the frame can be dragged.

What I didn't expect is that the resize button appears and works automatically!
One minor regression is that when you don't resize, the slideshow images are rather small related to the bigger window, but who cares if one knows how to resize the window?

The gain in more security while partitioning is a much bigger advantage.

Please change tat for the next issue, it's only one value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants