Support ro and user operation #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roxedus
reviewed
Jun 23, 2024
|
RO and --user together might be supported later, but right now I've not tested it properly & I'm waiting for a 3.2 bugfix first. |
This was referenced Jun 26, 2024
aptalca
reviewed
Jul 1, 2024
aptalca
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a set of core changes required to support read-only operation with some downstream images. It also lays the groundwork for potential support of --user with s6 3.2. Also requires some changes to the base images (see linuxserver/docker-baseimage-alpine#246 for example), both can be merged independently without breaking anything.
If testing, /run needs to be mounted to tmpfs with exec, and to stop warnings in the logs currently /var/spool/cron/crontabs also needs to be mounted to tmpfs.