adapt RocksDB v9.1.1 #148
Closed
adapt RocksDB v9.1.1 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any plan for this PR? |
|
It's better to make changes for 9.1.x instead. I will give it a try |
@linxGnu can we have a "adapt RocksDB v9.0.0" release? i am using the rocksdb 9.0.0 now. not easy to upgrade since there are customization of rocksdb. |
|
@aaronyuan I am on it. 50% of code will be based on this PR |
yihuang
commented
May 21, 2024
|
close in favor of #151 |
|
@aaronyuan we released new version of grocksdb which is compatible with rocksdb 9.1.1. PTAL |
how about the other 50%, is it compatible with rocksdb 9.0.0. I suppose no. right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's a zstd cmake issue, fixed in facebook/rocksdb#12309, either wait for the new release, or patch librocksdb locally.