Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcurl dependency #19

Closed
lipanski opened this issue Jun 1, 2017 · 4 comments
Closed

libcurl dependency #19

lipanski opened this issue Jun 1, 2017 · 4 comments

Comments

@lipanski
Copy link
Owner

lipanski commented Jun 1, 2017

dev-dependencies cannot be opted out (see this) and the libcurl dependencies poses problems when cross-compiling the crate.

originall reported here.

cc @lucab I'll try to think of something but I went for curl & http-muncher because the hyper server doesn't work on Windows (maybe I'll just use TcpStream + hyper only as a parser). libcurl is also way faster apparently.

@estin
Copy link
Contributor

estin commented Jun 1, 2017

And my thoughts about libcurl.

libcurl used only for making http POST requests to the mock server launched in the thread.

May use async channel to comunicate in threads to add/remove/reset mocks without http and serailization/desirailization?
Like https://tokio.rs/docs/going-deeper-futures/synchronization/#channels

Sorry for my poor English.

@lucab
Copy link
Contributor

lucab commented Jun 1, 2017

I guess @estin suggestion above is somehow tangled into the larger discussion of making mockito testthread-local. Whatever we'll end up doing here, it would be nice if it'd also account for that.

@lipanski
Copy link
Owner Author

@estin @lucab a great day for Mockito 🎉

0.8.0 removed the need for curl (and serde for that matter).

please check the changelog because with 0.7.0 I introduced some breaking changes, but also some new features.

@lucab
Copy link
Contributor

lucab commented Jul 11, 2017

👍 Thanks for pinging back, I'll give it a try soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants