Update Get-IniContent.ps1 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original code was creating a nested arraylist on the first item when keynames matched. Which caused the first items to be doubled up into two lists.
|
Appears the checks are not working properly? Please don't dismiss my PR because of them. |
|
Is the repo owner not maintaining this repo any more? I just checked and there are 5 or more (including mine) pull requests for this very same bug. All of which have been ignored. @lipkau can you please pull in one of the PRs? and publish a new module? |
|
the CI/CD pipeline has been broken for a while. I can push the changes manually, but I first I am interested in what versions of powershell are affected by this. Answer: |
|
version 3.1.3 is released |
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original code was creating a nested arraylist on the first item when keynames are the same. Which caused the first items to be doubled up into two lists.
Example:
Routes=8675309
Routes=1234567
Routes=2345678
Routes=3456789
Was read in, but then would output like below when Out-IniFile was called. The desired output would be to match the existing format. What's worse is that the first value in the list is lost. The line Routes=8675309 disappears when writing the file back out.
Routes= System.Collections.ArrayList 1234567 2345678 3456789
Routes=1234567
Routes=2345678
Routes=3456789