Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front-end Issues #38

Closed
mcastro-lqd opened this issue Oct 2, 2023 · 4 comments
Closed

Front-end Issues #38

mcastro-lqd opened this issue Oct 2, 2023 · 4 comments
Assignees
@philli-m
Labels
Type: UX/UI or design issue related to the design
Milestone
release October 23

Comments

@mcastro-lqd
Copy link

URL: https://defakts-dev.liqd.net
important screensize: Both
device & browser: Safari and Chrome
Comment/Question: Sorry it took so long, but here are some errors I found in Defakts. I decided to put everything on a pdf to make it faster.

test-defakts.pdf
@maxliqd maxliqd added the Type: UX/UI or design issue related to the design label Oct 10, 2023
@maxliqd maxliqd added this to the release October 23 milestone Oct 10, 2023
@philli-m
Copy link
Contributor

philli-m commented Oct 12, 2023 •
edited
Loading

  • 01 org name tab styling
  • tab shadow
  • transparent button behaviour
  • rating button colours to be changed
  • comment button behaviour?
  • padding mod button
  • close button on mob
  • bg blocks full width mobile
  • mod feedback on mobilie

@philli-m
Copy link
Contributor

@mcastro-lqd i'm not sure which 'dark one' button you are referring to in 03? also not sure what you mean by 'highlighted a bit'? sorry!

@mcastro-lqd
Copy link
Author

@philli-m Like, white strokes, text in Black and same hover.

Screenshot 2023-10-12 at 16 55 48

@philli-m philli-m self-assigned this Oct 17, 2023
philli-m added a commit that referenced this issue Oct 17, 2023
@philli-m
assets/header_lower: add styling for if no org logo partial fixes #38
166480d
philli-m added a commit that referenced this issue Oct 17, 2023
@philli-m
assets/*: update rating colours add to variable, change btns in comme…
e9c3683 
…nts to be consistent, increace alert lightening to work wi new colours fixes #38
philli-m added a commit that referenced this issue Oct 17, 2023
@philli-m
assets/header_lower: add styling for if no org logo partial fixes #38
3652b9a
philli-m added a commit that referenced this issue Oct 17, 2023
@philli-m
assets/*: update rating colours add to variable, change btns in comme…
2d58437 
…nts to be consistent, increace alert lightening to work wi new colours fixes #38
@philli-m
Copy link
Contributor

@mcastro-lqd thanks for the clarifications, as that element uses the same button as the lighter background components this needs a template refactor so will add it to a separate issue and remove from the milestone for now just dues to time pressure, sorry!

@philli-m philli-m mentioned this issue Oct 17, 2023
Closed
goapunk pushed a commit that referenced this issue Oct 17, 2023
@philli-m @goapunk
assets/*: update rating colours add to variable, change btns in comme…
01c656c 
…nts to be consistent, increace alert lightening to work wi new colours fixes #38
m4ra pushed a commit that referenced this issue Oct 18, 2023
@philli-m @m4ra
assets/header_lower: add styling for if no org logo partial fixes #38
0cf0a9f
m4ra pushed a commit that referenced this issue Oct 18, 2023
@philli-m @m4ra
assets/*: update rating colours add to variable, change btns in comme…
246ae24 
…nts to be consistent, increace alert lightening to work wi new colours fixes #38
goapunk pushed a commit that referenced this issue Jun 5, 2024
@philli-m @goapunk
assets/header_lower: add styling for if no org logo partial fixes #38
3811d40
goapunk pushed a commit that referenced this issue Jun 5, 2024
@philli-m @goapunk
assets/*: update rating colours add to variable, change btns in comme…
e26efd5 
…nts to be consistent, increace alert lightening to work wi new colours fixes #38
goapunk pushed a commit that referenced this issue Jun 19, 2024
@philli-m @goapunk
assets/header_lower: add styling for if no org logo partial fixes #38
9601f3b
goapunk pushed a commit that referenced this issue Jun 19, 2024
@philli-m @goapunk
assets/*: update rating colours add to variable, change btns in comme…
547e474 
…nts to be consistent, increace alert lightening to work wi new colours fixes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philli-m philli-m

Labels
Type: UX/UI or design issue related to the design
Projects
None yet
Milestone
release October 23
Development

No branches or pull requests
3 participants
@philli-m @mcastro-lqd @maxliqd