Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7540] Add component to display AI report text with dummy data for now #21

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Aug 14, 2023

…ponent and add to the ModerationNotification small a11y improvments

created a new branch from current rebased main and cherry picked commit from closed #11 due to making changes before realising remote version now had different history

@philli-m philli-m force-pushed the pm-2023-08-ai-text-component-rebased branch from d5977f8 to cc82a66 Compare August 14, 2023 08:24
@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 12.62% 90/713
🔴 Branches 14.84% (+1.43% 🔼) 54/364
🔴 Functions 10.42% 27/259
🔴 Lines 24.49% (+1.32% 🔼) 569/2323

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show new covered files 🌑

Coverage of new files

Status Filename Statements Branches Functions Lines
🟢 apps/userdashboard/assets/js/a4_candy_userdashboard/AiReportExplanation.jsx 100% 100% 100% 100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 306b6ee

@philli-m philli-m force-pushed the pm-2023-08-ai-text-component-rebased branch from cc82a66 to b6f4c96 Compare August 14, 2023 08:30
…ponent and add to the ModerationNotification small a11y improvments
@philli-m philli-m force-pushed the pm-2023-08-ai-text-component-rebased branch from b6f4c96 to 306b6ee Compare August 14, 2023 08:57
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am working on the serializer, do you want to wait and update the FIXME? @philli-m

@philli-m
Copy link
Contributor Author

@m4ra I have another PR for the switch component which is relying on this one so happy to have this merged and can update the WIP switch one and update the FIXME there is that's good with you?

@m4ra
Copy link
Contributor

m4ra commented Aug 14, 2023

Yes sure! Can you do a local rebase and push again? with fetch --all, and then git rebase main on this branch

@m4ra m4ra merged commit 25ca25c into main Aug 14, 2023
2 checks passed
@m4ra m4ra deleted the pm-2023-08-ai-text-component-rebased branch August 14, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants