Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ks 2021 04 add use ai setting #121

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Conversation

Rineee
Copy link
Contributor

@Rineee Rineee commented Apr 26, 2021

@fuzzylogic2000 I now set the default to not use the ai, thus I would then add it to local settings for dev on pillar to use the ai. Or do you prefer the other way around?

There is a PR for adding the setting on pillar: https://github.com/liqd/admin/pull/287

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supernice! But should we enable the API here and only add the token to the pillar?

@@ -544,3 +544,4 @@

AI_API_AUTH_TOKEN = ''
AI_API_URL = 'https://kosmo-api-dev.liqd.net/api/classify/'
AI_USAGE = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, instead of adding this to pillar, we could set it to True here. Then if we deploy and forget to add the token to the pillar, we will get a warning!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right!

@Rineee Rineee force-pushed the ks-2021-04-add-use-ai-setting branch from ce91b8a to 642f281 Compare April 27, 2021 08:36
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop whoop!

@fuzzylogic2000 fuzzylogic2000 merged commit 0eb0c85 into master Apr 27, 2021
@fuzzylogic2000 fuzzylogic2000 deleted the ks-2021-04-add-use-ai-setting branch April 27, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants