Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps/userdashboard: mobile styling for userdashboard and child pages #42

Merged
merged 4 commits into from
Jan 25, 2021
Merged

apps/userdashboard: mobile styling for userdashboard and child pages #42

merged 4 commits into from
Jan 25, 2021

Conversation

philli-m
Copy link
Contributor

No description provided.

@philli-m philli-m force-pushed the pm-2021-01-mobile branch 2 times, most recently from 6998049 to 92891c0 Compare January 21, 2021 16:35
@philli-m philli-m changed the title WIP apps/userdashboard: mobile styling for userdashboard and child pages apps/userdashboard: mobile styling for userdashboard and child pages Jan 21, 2021
fuzzylogic2000
fuzzylogic2000 reviewed Jan 22, 2021
View reviewed changes
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good in the profile!
But it moved the chevrons (are they called that?) in the dashboard to a weird place:
Screenshot from 2021-01-22 09-47-14

apps/userdashboard/views.py Show resolved Hide resolved
@philli-m
Copy link
Contributor Author

@fuzzylogic2000 can't seem to resolve the chevron comment but thats now fixed

fuzzylogic2000
fuzzylogic2000 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it really looks fine. 🤔

@fuzzylogic2000 fuzzylogic2000 merged commit 6652e60 into master Jan 25, 2021
@fuzzylogic2000 fuzzylogic2000 deleted the pm-2021-01-mobile branch January 25, 2021 10:38
@hmkay hmkay mentioned this pull request May 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzylogic2000 fuzzylogic2000 fuzzylogic2000 approved these changes

@Rineee Rineee Awaiting requested review from Rineee

@rmader rmader Awaiting requested review from rmader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philli-m @fuzzylogic2000 @Rineee