Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6669 email notification on feedback to contribution: status not shown + styling of "Rückmeldung" is off #4850

Closed
2 tasks
jostertag opened this issue Jan 17, 2023 · 17 comments · Fixed by #4954
Closed
2 tasks
Assignees

Comments

@jostertag
Copy link

jostertag commented Jan 17, 2023

URL: notification on new feedback to contribution via this post https://meinberlin-dev.liqd.net/budgeting/2023-00976/
user: reg. user
expected behaviour:
As user I want to see the status of my proposal in the E-Mail notification. As a user I want that everything is centred.

behaviour:

  • as user I just see "" (see screenshot) and no status in the E-Mail notification.
  • The position of the word "Rückmeldung" looks odd, because it is on the left side and not centred.

important screensize: -
device & browser: mac , thunderbird mail
Comment/Question: maybe related to this closed issue #4807 ?

Bildschirm­foto 2023-01-17 um 15 27 00

Screenshot?

@jostertag
Copy link
Author

@CarolingerSeilchenspringer as you can see in the screenshot, the position of the word "Rückmeldung" looks also a bit odd, because it is on the left side and not centred. Should that be changed too?

@CarolingerSeilchenspringer
Copy link
Contributor

@jostertag Yes, it should all be centered. If the status is empty then I believe it should not show the whole sentence, as I remember that is how it was before.

@jostertag jostertag changed the title #6669 email notification on feedback to contribution: status not shown #6669 email notification on feedback to contribution: status not shown + styling of "Rückmeldung" is off Jan 17, 2023
@jostertag
Copy link
Author

jostertag commented Jan 17, 2023

@CarolingerSeilchenspringer in the case above I changed the status to "wird geprüft". If the status is empty, then the wording is correct (as you can see in the screenshot)
Bildschirm­foto 2023-01-17 um 17 58 26

@fuzzylogic2000
Copy link
Contributor

@CarolingerSeilchenspringer We cannot have everything centered and the bullet points not look odd at the same time. I think, the feedback itseld should be left aligned, but everything else centered?
Should the title "Rückmeldung" above the feedback be centered or left aligned?
Actually @mcastro-lqd needs to answer that.

@CarolingerSeilchenspringer
Copy link
Contributor

@fuzzylogic2000 for the b-plan-statements we also decided to make the whole mail (starting with "Guten Tag") left aligned because it looked wired for longer texts. I'd suggest to do the same here unless @mcastro-lqd has another idea. Bildschirmfoto 2023-01-23 um 10 13 51

@fuzzylogic2000
Copy link
Contributor

@CarolingerSeilchenspringer What is the status here? We cannot deploy it like that, right? For now I propose to change the failed fix for the bullets back. (a288829) Or do you have an idea how we can make the content of the feedback text left aligned @phillimorland ?

@philli-m
Copy link
Contributor

philli-m commented Feb 9, 2023

@fuzzylogic2000 if I remember the issue correctly I think we can add nested inline styles for lists to be left aligned but I would have to check, I'm also not totally clear on current state of this, did left align not work?

@fuzzylogic2000
Copy link
Contributor

@phillimorland Looks like it only worked for the "Rückmeldung", which is the text from the email, but not the richtext we get from the model. I did not check, it looked so right,...

@mcastro-lqd
Copy link
Contributor

@CarolingerSeilchenspringer I'd recommend Main title and Subhead Centered and content aligned to the left, no longer text should be centred.

@philli-m
Copy link
Contributor

philli-m commented Feb 9, 2023

@fuzzylogic2000 we might have a bit of an issue with the richtext here but i'll have a play and see what can be done.
@CarolingerSeilchenspringer what is the ideal format for the emails if possible?

@CarolingerSeilchenspringer
Copy link
Contributor

@phillimorland let's go with what @mcastro-lqd wrote then as this is also what we do for bplan statement (see screenshot above).

@philli-m
Copy link
Contributor

philli-m commented Feb 9, 2023

@CarolingerSeilchenspringer can you forward me the problematic emails, will look monday

@jostertag
Copy link
Author

@phillimorland I forwarded the e-mails to you

@philli-m philli-m removed the Status: Decision Needed Issues that are blocked because decision is needed label Feb 13, 2023
@philli-m philli-m self-assigned this Feb 13, 2023
philli-m added a commit that referenced this issue Feb 13, 2023
…yling to container div when there is feedback text fixes #4850
philli-m added a commit that referenced this issue Feb 13, 2023
…yling to container div when there is feedback text fixes #4850
philli-m added a commit that referenced this issue Feb 13, 2023
…yling to container div when there is feedback text fixes #4850
fuzzylogic2000 pushed a commit that referenced this issue Feb 13, 2023
…yling to container div when there is feedback text fixes #4850
@jostertag jostertag reopened this Feb 17, 2023
@jostertag
Copy link
Author

I still get e-mails with the wrong styling of wording. It is still all centered, except of the word "Rückmeldung" (see screenshot).

Bildschirm­foto 2023-02-17 um 12 28 28

@jostertag
Copy link
Author

Ok my bad! It was just on demo.

@jostertag jostertag reopened this Feb 17, 2023
@jostertag
Copy link
Author

jostertag commented Feb 17, 2023

before I close the issue, I wanted to know, whether the issue was fixed before demo was released or not? and whether it is possible that it looks off on stage/prod as well?

@Rineee
Copy link
Contributor

Rineee commented Feb 17, 2023

@jostertag The commit that fixes this issue was merged after demo release, so if it is fine on dev, the issue can be closed. It will probably also be on stage/prod (depending on when it was introduced), but should then be fixed with next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants