-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6669 email notification on feedback to contribution: status not shown + styling of "Rückmeldung" is off #4850
Comments
@CarolingerSeilchenspringer as you can see in the screenshot, the position of the word "Rückmeldung" looks also a bit odd, because it is on the left side and not centred. Should that be changed too? |
@jostertag Yes, it should all be centered. If the status is empty then I believe it should not show the whole sentence, as I remember that is how it was before. |
@CarolingerSeilchenspringer in the case above I changed the status to "wird geprüft". If the status is empty, then the wording is correct (as you can see in the screenshot) |
@CarolingerSeilchenspringer We cannot have everything centered and the bullet points not look odd at the same time. I think, the feedback itseld should be left aligned, but everything else centered? |
@fuzzylogic2000 for the b-plan-statements we also decided to make the whole mail (starting with "Guten Tag") left aligned because it looked wired for longer texts. I'd suggest to do the same here unless @mcastro-lqd has another idea. |
@CarolingerSeilchenspringer What is the status here? We cannot deploy it like that, right? For now I propose to change the failed fix for the bullets back. (a288829) Or do you have an idea how we can make the content of the feedback text left aligned @phillimorland ? |
@fuzzylogic2000 if I remember the issue correctly I think we can add nested inline styles for lists to be left aligned but I would have to check, I'm also not totally clear on current state of this, did left align not work? |
@phillimorland Looks like it only worked for the "Rückmeldung", which is the text from the email, but not the richtext we get from the model. I did not check, it looked so right,... |
@CarolingerSeilchenspringer I'd recommend Main title and Subhead Centered and content aligned to the left, no longer text should be centred. |
@fuzzylogic2000 we might have a bit of an issue with the richtext here but i'll have a play and see what can be done. |
@phillimorland let's go with what @mcastro-lqd wrote then as this is also what we do for bplan statement (see screenshot above). |
@CarolingerSeilchenspringer can you forward me the problematic emails, will look monday |
@phillimorland I forwarded the e-mails to you |
…yling to container div when there is feedback text fixes #4850
…yling to container div when there is feedback text fixes #4850
…yling to container div when there is feedback text fixes #4850
…yling to container div when there is feedback text fixes #4850
Ok my bad! It was just on demo. |
before I close the issue, I wanted to know, whether the issue was fixed before demo was released or not? and whether it is possible that it looks off on stage/prod as well? |
@jostertag The commit that fixes this issue was merged after demo release, so if it is fine on dev, the issue can be closed. It will probably also be on stage/prod (depending on when it was introduced), but should then be fixed with next release. |
URL: notification on new feedback to contribution via this post https://meinberlin-dev.liqd.net/budgeting/2023-00976/
user: reg. user
expected behaviour:
As user I want to see the status of my proposal in the E-Mail notification. As a user I want that everything is centred.
behaviour:
important screensize: -
device & browser: mac , thunderbird mail
Comment/Question: maybe related to this closed issue #4807 ?
Screenshot?
The text was updated successfully, but these errors were encountered: