-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project header/item styling #330
Conversation
# Conflicts: # apps/contrib/templates/meinberlin_contrib/item_detail.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR, very well structured!
I found some small issues
-
There are more places where comments are used (just grep for
react_comments
). Please either change it everywhere or revert to the old system. -
I think that
item
might be too generic for a component name. Maybe useitem-detail
instead.
# Conflicts: # apps/polls/templates/meinberlin_polls/poll_detail.html
No description provided.