Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kt 2021 proposalitem features conditions #3984

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

khamui
Copy link
Contributor

@khamui khamui commented Nov 25, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 25, 2021

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 3.06% 38/1241
🔴 Branches 2.8% 20/714
🔴 Functions 4.15% 17/410
🔴 Lines 6.76% (+1.58% 🔼) 247/3653

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 622145c

Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, just that typo :)

meinberlin/apps/budgeting/assets/BudgetingProposalList.jsx Outdated Show resolved Hide resolved
expect(screen.getByText('myProposal')).toBeTruthy()
expect(screen.getByText('creator')).toBeTruthy()
expect(screen.getByText('11. mock text 2021')).toBeTruthy()
})
Copy link
Contributor

@philli-m philli-m Nov 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khamui oh and can we keep putting tests in __tests__ folder like the others, it's much easier to see whats what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah oh, yes of course. I forgot about that..will fix

…ording features

- removing django list and keep react list only
- adding tests
@khamui khamui force-pushed the kt-2021-proposalitem-features-conditions branch from 29ea0ac to 622145c Compare November 25, 2021 14:05
@khamui khamui requested a review from philli-m November 25, 2021 14:05
@philli-m philli-m merged commit 3c8e864 into main Nov 25, 2021
@philli-m philli-m deleted the kt-2021-proposalitem-features-conditions branch November 25, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants