Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5616] reduce slider arrow size #5631

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

hom3mad3
Copy link
Contributor

Describe your changes
fixes #5616

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@hom3mad3 hom3mad3 requested review from goapunk and m4ra June 20, 2024 10:43
@hom3mad3 hom3mad3 changed the title scss/components/_poll.scss: reduce slider arrow size [#5616] reduce slider arrow size Jun 20, 2024
@goapunk
Copy link
Contributor

goapunk commented Jun 24, 2024

The buttons and the numbers now overlap for me:

Screenshot 2024-06-24 at 15-45-15 liqd-project — meinBerlin

Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buttons and counter overlap for me on firefox, see screenshot in comment

@hom3mad3 hom3mad3 force-pushed the mr-2024-06-reduce-poll-slider-arrows branch from 689ef66 to 0b549ee Compare June 26, 2024 14:52
@hom3mad3 hom3mad3 requested a review from goapunk June 26, 2024 14:54
@hom3mad3 hom3mad3 force-pushed the mr-2024-06-reduce-poll-slider-arrows branch from 0b549ee to 34272c6 Compare June 27, 2024 13:07
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@goapunk goapunk merged commit c26febe into main Jun 27, 2024
3 checks passed
@goapunk goapunk deleted the mr-2024-06-reduce-poll-slider-arrows branch June 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation icon for open answer in survey module too large
2 participants