Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm 2020 05 popover removal #1881

Merged
merged 1 commit into from
May 6, 2020
Merged

Pm 2020 05 popover removal #1881

merged 1 commit into from
May 6, 2020

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented May 6, 2020

sorry I thought I checked for file name but obviously not, why did it work locally though?!

@philli-m philli-m requested a review from rmader May 6, 2020 10:09
@philli-m philli-m force-pushed the pm-2020-05-popover-removal branch from 67c92e1 to d924c29 Compare May 6, 2020 10:11
Copy link
Contributor

@rmader rmader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thx! Locally we do not use whitenoise and missing things are just gracefully ignored. On the server, if a non-existing file is requested, things break hard :/

@rmader rmader merged commit 8e9259e into master May 6, 2020
@rmader rmader deleted the pm-2020-05-popover-removal branch May 6, 2020 10:39
@philli-m
Copy link
Contributor Author

philli-m commented May 6, 2020

thanks for explaining and sorry you have to deploy during your fixes! :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants