Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate document on rest api #788

Merged
merged 2 commits into from
Apr 19, 2017

Conversation

slomo
Copy link
Contributor

@slomo slomo commented Apr 19, 2017

No description provided.

 - remove linting errors after pylint update
Copy link
Contributor

@MagdaN MagdaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the one comment



def single_document_per_module(module, pk=None):
from .models import Document
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this go to the top of the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried and it results in an import loop. Do you have any Idea how I could prevent that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgh, well that we have to stick to it (maybe add a comment?)

@MagdaN MagdaN merged commit ca0585f into master Apr 19, 2017
@MagdaN MagdaN deleted the ym-2017-04-validate-document-via-rest-api branch April 19, 2017 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants