This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
organisations: Stop using the organisations middleware #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmader
force-pushed
the
rm-2019-07-partners-cleanup
branch
from
a154ebb
to
3d65e30
Compare
rmader
changed the title
rmader
force-pushed
the
rm-2019-07-partners-cleanup
branch
from
3d65e30
to
1837a1b
Compare
rmader
commented
Aug 1, 2019
| Module.add_to_class("get_absolute_url", module_get_absolute_url) | ||
| Project.add_to_class("get_absolute_url", project_get_absolute_url) | ||
| ProjectFormComponent.get_base_url = project_get_base_url | ||
| ModuleFormComponent.get_base_url = module_get_base_url |
There was a problem hiding this comment.
These ones might be debatable @MagdaN :)
But IMHO still better than the (from us here) badly understood middleware.
MagdaN
suggested changes
Aug 1, 2019
liqd_product/templates/a4reports/emails/report_creator.de.email
Outdated
Show resolved
Hide resolved
liqd_product/templates/a4reports/emails/report_creator.en.email
Outdated
Show resolved
Hide resolved
liqd_product/templates/a4reports/emails/report_moderator.en.email
Outdated
Show resolved
Hide resolved
liqd_product/templates/a4reports/emails/report_moderators.de.email
Outdated
Show resolved
Hide resolved
rmader
force-pushed
the
rm-2019-07-partners-cleanup
branch
from
9a2a192
to
81a64dc
Compare
Instead of using the organisations/partners middleware, make the organisation slug explicit in all templates, views, urls etc. The only visible change here is that the dashboard now also uses the organisation slug.
rmader
force-pushed
the
rm-2019-07-partners-cleanup
branch
from
81a64dc
to
b3757d7
Compare
|
Looking good for me and working :) |
fuzzylogic2000
suggested changes
Aug 2, 2019
There was a problem hiding this comment.
Alright, it reads well, but the links to old projects are not working and on the links for old projects (created still in current master branch) are not working, while newly created projects work fine. Also the header is the platform header (and not the partner/orga-header) anywhere.
And the timeline is a bit broken: the previous and next-buttons are in the wrong place.
|
@MagdaN Let's look at it together next week! |
|
@fuzzylogic2000 I can't reproduce you problem with the links but I fixed the header |
fuzzylogic2000
approved these changes
Aug 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the organisations/partners middleware, make the organisation
slug explicit in all templates, views, urls etc.
The only visible change here is that the dashboard now also uses the organisation slug.
This might require some manual testing to make sure nothing was left out that is not tested within the test suite.