Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modal dialog not hidden from screen readers #110

Closed
xi opened this issue Jun 20, 2017 · 0 comments · Fixed by #143
Closed

modal dialog not hidden from screen readers #110

xi opened this issue Jun 20, 2017 · 0 comments · Fixed by #143
Assignees
@xi

Comments

@xi
Copy link
Contributor

xi commented Jun 20, 2017

Once they are show/hidden with javascript, the aria-hidden attribute is set correctly. But we need to set the initial value manually.
@xi xi added the bug label Jun 20, 2017
xi pushed a commit that referenced this issue Jul 25, 2017
set initial aria-hidden on modals
ad80b33 
fixes #110
@xi xi mentioned this issue Jul 25, 2017
Merged
@xi xi self-assigned this Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xi xi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set initial aria-hidden on modals liqd/adhocracy4
1 participant
@xi