ui to explain follow #164
Merged
ui to explain follow #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slomo
approved these changes
Aug 29, 2017
| <span className="dropdown-menu" aria-labelledby="follow-dropdown"> | ||
| <button className="dropdown-item select-item" onClick={this.disableFollow.bind(this)}> | ||
| {!this.state.followed ? <i className="fa fa-check select-item-indicator" aria-hidden="true" /> : null} | ||
| {django.gettext('Unfollow')} |
There was a problem hiding this comment.
Shouldn't this be named Not following and the other option Following?
There was a problem hiding this comment.
Valid point, thanks!
| <i className="fa fa-caret-down" aria-hidden="true" /> | ||
| </button> | ||
| <span className="dropdown-menu" aria-labelledby="follow-dropdown"> | ||
| <button className="dropdown-item select-item" onClick={this.disableFollow.bind(this)}> |
There was a problem hiding this comment.
Is the class name select-item not a bit over generic?
There was a problem hiding this comment.
I had something like followbefore which I found too specific. You have any suggestions for something in between?
vellip
force-pushed
the
2017-08-pv-update-follow
branch
from
c4f9226
to
bf8561d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking the button now opens a dropdown where the specific action is explained.
This is breaking because it requires additional styling. See liqd/a4-meinberlin#728. At least setting
is recommended, since I couldn't use any block elements due to then invalid html.