[#6598] gruenbuch/models: extend oveview page to create index page with migra… #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philli-m
commented
Nov 1, 2022
| help_text=apps_blocks.HELPTEXT_RICHTEXT_A11Y) | ||
| page_intro_de_ls = fields.RichTextField( | ||
| blank=True, default="", | ||
| verbose_name="Grünbuch Overview page introduction", | ||
| verbose_name="Page introduction de ls", |
There was a problem hiding this comment.
so it matches title form fields and can be used generically
philli-m
force-pushed
the
pm-2022-11-index-page
branch
from
208578b
to
3899f9f
Compare
philli-m
commented
Nov 2, 2022
philli-m
force-pushed
the
pm-2022-11-index-page
branch
from
3899f9f
to
36f4d63
Compare
Rineee
reviewed
Nov 2, 2022
| @@ -115,6 +116,15 @@ class GruenbuchOverviewPage(MetadataPageMixin, Page): | |||
| ] | |||
|
|
|||
|
|
|||
| class GruenbuchIndexPage(GruenbuchOverviewPage): | |||
| template = 'gruenbuch_overview_page.html' | |||
There was a problem hiding this comment.
Its the same as parent page, right? So do you need that again?
There was a problem hiding this comment.
when I didn't have it it automatically looked for a template called index_page which didn't exist
Rineee
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion
I don't know if this is the best way to do this?!