Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6603] home/blocks: add new video block with template #541

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Nov 3, 2022

@philli-m philli-m changed the title home/blocks: add new video block with template [#6603] home/blocks: add new video block with template Nov 3, 2022
@philli-m philli-m changed the title [#6603] home/blocks: add new video block with template WIP[#6603] home/blocks: add new video block with template Nov 3, 2022
@philli-m philli-m force-pushed the pm-2022-11-video-block branch 4 times, most recently from 058471b to 18da8b5 Compare November 7, 2022 16:43
@philli-m philli-m force-pushed the pm-2022-11-video-block branch 3 times, most recently from 86df7d1 to eb43f1d Compare November 7, 2022 17:07
@philli-m philli-m changed the title WIP[#6603] home/blocks: add new video block with template [#6603] home/blocks: add new video block with template Nov 7, 2022
@philli-m philli-m force-pushed the pm-2022-11-video-block branch 2 times, most recently from fd9cfb2 to 5d42f33 Compare November 8, 2022 08:29
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely and looks great!

apps/home/templates/apps_home/blocks/video_block.html Outdated Show resolved Hide resolved
apps/home/templates/apps_home/blocks/video_block.html Outdated Show resolved Hide resolved
digitalstrategie/settings/base.py Show resolved Hide resolved
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Still looks good and works great. :)
We can merge now and delete the strings later or you delete them and then merge, whatever you prefer!

Comment on lines +389 to +394

#~ msgid "For more information see"
#~ msgstr "For more information see"

#~ msgid "To protect your privacy this video can\\\\"
#~ msgstr "To protect your privacy this video can\\\\"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unused strings should be deleted from the files again.

Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool!

@goapunk goapunk merged commit 993377d into main Nov 8, 2022
@goapunk goapunk deleted the pm-2022-11-video-block branch November 8, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants