Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps/contrib: make sure lower footer is only loaded if response ok #629

Merged
merged 1 commit into from
Apr 12, 2023
Merged

apps/contrib: make sure lower footer is only loaded if response ok #629

merged 1 commit into from
Apr 12, 2023

Conversation

fuzzylogic2000
Copy link
Contributor

I think this is an improvement, but couldn't properly try.

@philli-m philli-m self-assigned this Apr 6, 2023
philli-m
philli-m reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when testing the lower footer is not shown, it is shown on main however, maybe the timeout is too quick?

@philli-m philli-m removed their assignment Apr 6, 2023
@fuzzylogic2000
Copy link
Contributor Author

when testing the lower footer is not shown, it is shown on main however, maybe the timeout is too quick?

It did work for me locally, but we can also use 2 or 5 seconds? Does that work locally for you? @philli-m

@philli-m
Copy link
Contributor

philli-m commented Apr 6, 2023

@fuzzylogic2000 2s works

@fuzzylogic2000 fuzzylogic2000 force-pushed the kl-2023-04-more-robust-meta-tags branch from 252de03 to a4a2204 Compare April 6, 2023 13:04
philli-m
philli-m approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@philli-m philli-m merged commit bc44f2a into main Apr 12, 2023
@philli-m philli-m deleted the kl-2023-04-more-robust-meta-tags branch April 12, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philli-m philli-m philli-m approved these changes

@goapunk goapunk Awaiting requested review from goapunk

@Rineee Rineee Awaiting requested review from Rineee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuzzylogic2000 @philli-m