-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7261] apps/measures/index page: add pagination and filters #688
Conversation
Help! I went a bit crazy with the filters (which are crazy themselves) in the second commit and now I cannot see the wood for the trees (I looked it up, also works in English 🤣 ) @Rineee @goapunk Can you have a look and point at the wood if there is one? Ehm, I mean point out what can be improved. I will spent the meantime with building the crazy urls in the frontend. |
c541380
to
0a8a605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, it works really well!
Only 2 little questions/suggestions.
And I was trying to write the filtering stuff for the lists a bit shorter, but did not really succeed :) A maybe a little shorter way would be sth like here, but yeah, not a super great improvement
Couldnt help but trying out a bit and came up with this MASSIVE improvement 🤣
But yeah, for readibility probably yours is better, so I am totally fine with both! |
0a8a605
to
ba4e2f0
Compare
Alright, thanks! I will merge then. @Rineee And I did change your other suggestions. :) |
No description provided.