Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homepage: fix title not shown without background image #812

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Jun 20, 2023

fixes #803

@goapunk goapunk requested a review from philli-m June 20, 2023 16:06
// overwrite of herounit text box
.ds-hero-image__overlay {
@extend .ds-hero-no-image;
Copy link
Contributor

@philli-m philli-m Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @extend overwrites any other styling you add if it clashes with the extended styling I would more inclined to add the .ds-hero-image__overlayclass to the styling above so have

.ds-hero-no-image,
 ds-hero-image__overlay {
        margin-bottom: 5 * $spacer !important;
        text-align: center;
 }

 // overwrite of herounit text box
 .ds-hero-image__overlay { ect.

but as it's more a coding syntax choice so easy either way

Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to change the styling go for it but it's not essential so also feel free to merge without refactor

@goapunk goapunk force-pushed the jd-2023-06-fix-homepage-title-no-image branch from f200d15 to eef101d Compare June 20, 2023 16:14
@goapunk goapunk requested a review from philli-m June 20, 2023 16:15
@goapunk goapunk force-pushed the jd-2023-06-fix-homepage-title-no-image branch from eef101d to 55bd829 Compare June 20, 2023 16:17
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! :)

@philli-m philli-m merged commit ddefbc5 into main Jun 20, 2023
@philli-m philli-m deleted the jd-2023-06-fix-homepage-title-no-image branch June 20, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LS no title on big screens if hero image not chosen
2 participants