-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RouteOperator idempotency #280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alacuku
force-pushed
the
kcl/routeOperatorIdempotency
branch
from
September 22, 2020 10:43
c2c988b
to
dac0c78
Compare
alacuku
force-pushed
the
kcl/routeOperatorIdempotency
branch
13 times, most recently
from
September 23, 2020 12:59
2615b30
to
a2a0da0
Compare
alacuku
force-pushed
the
kcl/routeOperatorIdempotency
branch
from
September 23, 2020 15:37
a2a0da0
to
27dcfbf
Compare
Pull Request Test Coverage Report for Build 269194716
💛 - Coveralls |
/rebase |
Rebase status: success! |
adamjensenbot
force-pushed
the
kcl/routeOperatorIdempotency
branch
from
September 23, 2020 15:54
27dcfbf
to
9c8f512
Compare
alacuku
force-pushed
the
kcl/routeOperatorIdempotency
branch
2 times, most recently
from
September 23, 2020 17:27
d17fceb
to
88a9bdf
Compare
alacuku
force-pushed
the
kcl/routeOperatorIdempotency
branch
from
September 23, 2020 17:39
88a9bdf
to
fc94b26
Compare
palexster
approved these changes
Sep 24, 2020
aleoli
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new way to manage the iptables rules for a remote peering cluster.
There are four general iptables chains:
for each peering cluster we create a postrouting, prerouting, forward and input chain. After each chain has been populated by rules based on the network parameters a reference for each of them is added to the general iptables chains.
All the methods used to manages the iptables rules and routes are idempotent. If some network parameters for peering cluster such as GatewayIP, PodCIDR change then the iptables rules and routes are updated accordingly to ensure the network connection with the peering cluster.
Fixes #257
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
unit tests