Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Liqo Installer #549

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Update Liqo Installer #549

merged 1 commit into from
Apr 6, 2021

Conversation

palexster
Copy link
Member

@palexster palexster commented Mar 31, 2021 •
edited
Loading

Description

This PR refactors the Liqo installer:

  • comments out the AppVersion to simplify the release of new Liqo versions and removes a legacy index.YAML file.
  • Remove legacy gateway node logic
  • Disable the installation of Liqo dashboard by default

@adamjensenbot
Copy link
Collaborator

Hi @palexster. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /ok-to-test Enable testing for PRs with base on forks

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@palexster palexster changed the title Comment AppVersion in Liqo Chart [WIP] Comment AppVersion in Liqo Chart Mar 31, 2021
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 31, 2021
@pull-request-size pull-request-size bot added size/S and removed size/M labels Mar 31, 2021
@palexster palexster changed the title [WIP] Comment AppVersion in Liqo Chart Comment AppVersion in Liqo Chart Mar 31, 2021
@palexster palexster requested review from alacuku, mlavacca, a team and aleoli March 31, 2021 08:08
@palexster
Copy link
Member Author

/rebase

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 31, 2021
@palexster palexster changed the title Comment AppVersion in Liqo Chart [WIP] Comment AppVersion in Liqo Chart Mar 31, 2021
@palexster palexster force-pushed the apa/appversion branch 5 times, most recently from 8a59497 to 10cc740 Compare March 31, 2021 16:55
@palexster palexster changed the title [WIP] Comment AppVersion in Liqo Chart Comment AppVersion in Liqo Chart Mar 31, 2021
@palexster palexster changed the title Comment AppVersion in Liqo Chart Update Liqo Installer Mar 31, 2021
@palexster
Copy link
Member Author

/rebase

@palexster palexster requested a review from giorio94 April 1, 2021 13:04
giorio94
giorio94 approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly ok, just some minor comments

install.sh Outdated
Comment on lines 65 to 66
# LiqoAgent is a desktop application (currently just for linux-based desktop environments) providing an easy way
# to manage Liqo through a simple graphical user interface. Learn more at https://github.com/liqotech/liqo-dashboard.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated

install.sh Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 6, 2021
@palexster
Copy link
Member Author

/rebase

@palexster
Installer Refactoring
27d43d1 
This Commit refactors the installer removing legacy code and adding support for the Helm Chart. In addition, it adds the trigger for the release pipeline.
@palexster
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Apr 6, 2021
@adamjensenbot adamjensenbot merged commit 2711153 into master Apr 6, 2021
@adamjensenbot adamjensenbot deleted the apa/appversion branch April 6, 2021 14:24
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca mlavacca approved these changes

@giorio94 giorio94 giorio94 approved these changes

@alacuku alacuku Awaiting requested review from alacuku

@aleoli aleoli Awaiting requested review from aleoli

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@palexster @adamjensenbot @giorio94 @mlavacca