Fix: Freeing a reserved subnet equal to a network pool #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
|
Hi @davidefalcone1. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
Hi @davidefalcone1. Thanks for your PR! I'm waiting for a Liqo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test. Once the patch is verified, the new status will be reflected by the ok-to-test label. |
This was
linked to
issues
Apr 14, 2021
davidefalcone1
force-pushed
the
dfa/fixipam
branch
from
8fbfd67
to
e8e6d50
Compare
alacuku
approved these changes
Apr 15, 2021
palexster
approved these changes
Apr 15, 2021
|
/rebase |
adamjensenbot
force-pushed
the
dfa/fixipam
branch
from
e8e6d50
to
d77768f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug that arises when freeing a reserved network equal to a network pool. Currently the Ipam removes completely the network pool and no cluster can ask/be mapped to that pool.
This PR also improves Ipam behavior if a cluster asks for an entire network pool. Currently it just looks for a mapping. If none is found, then returns an error. Thanks to this correction, if a mapping has not been found, the entire network pool is assigned to the cluster.