Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate unit test pipeline to docker #636

Merged
merged 1 commit into from
May 20, 2021
Merged

Migrate unit test pipeline to docker #636

merged 1 commit into from
May 20, 2021

Conversation

palexster
Copy link
Member

@palexster palexster commented May 19, 2021 •
edited
Loading

Description

This PR:

  • migrates the unit tests to the new docker container introduced in Added Docker container for unit tests #629.
  • reduces the time needed to build liqo images by optimizing the Dockerfile, fostering caching of container layers.

@adamjensenbot
Copy link
Collaborator

Hi @palexster. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /ok-to-test Enable testing for PRs with base on forks

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@coveralls
Copy link

coveralls commented May 19, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 40.44% when pulling 62b20b6 on apa/docker-build into 80694cf on master.

@palexster palexster force-pushed the apa/docker-build branch 8 times, most recently from de466f9 to 5d4ea61 Compare May 19, 2021 15:01
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 19, 2021
@palexster palexster changed the title [WIP] Optimize docker images build time Migrate unit test pipeline to docker May 19, 2021
@pull-request-size pull-request-size bot added size/M and removed size/L labels May 19, 2021
giorio94
giorio94 approved these changes May 19, 2021
View reviewed changes
build/advertisement-broadcaster/Dockerfile Show resolved Hide resolved
build/liqo-test/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 20, 2021
@palexster palexster added the hold Prevent bot merging label May 20, 2021
@palexster palexster force-pushed the apa/docker-build branch 2 times, most recently from 69a970d to 62b20b6 Compare May 20, 2021 10:14
@palexster
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added merge-requested Request bot merging (automatically managed) and removed merge-requested Request bot merging (automatically managed) labels May 20, 2021
@palexster palexster removed the hold Prevent bot merging label May 20, 2021
@palexster
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label May 20, 2021
@adamjensenbot adamjensenbot merged commit cc05ac0 into master May 20, 2021
@adamjensenbot adamjensenbot deleted the apa/docker-build branch May 20, 2021 11:45
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alacuku alacuku alacuku approved these changes

@giorio94 giorio94 giorio94 approved these changes

@aleoli aleoli Awaiting requested review from aleoli

@davidefalcone1 davidefalcone1 Awaiting requested review from davidefalcone1

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@palexster @adamjensenbot @coveralls @alacuku @giorio94