Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate ClusterID During Helm Installation #908

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Generate ClusterID During Helm Installation #908

merged 1 commit into from
Sep 24, 2021

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Sep 22, 2021 •
edited
Loading

Description

This pr moves the logic of clusterID creation in the helm chart

How Has This Been Tested?

  • locally on KinD
  • existent E2E test

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /doc-build Trigger the build of the Liqo documentation

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli mentioned this pull request Sep 23, 2021
Closed
4 tasks
@aleoli
Copy link
Member Author

aleoli commented Sep 23, 2021

/test

@aleoli
Copy link
Member Author

aleoli commented Sep 23, 2021

/test

@aleoli aleoli marked this pull request as ready for review September 23, 2021 14:10
giorio94
giorio94 approved these changes Sep 24, 2021
View reviewed changes
deployments/liqo/templates/liqo-auth-deployment.yaml Outdated Show resolved Hide resolved
deployments/liqo/templates/liqo-crd-replicator-deployment.yaml Outdated Show resolved Hide resolved
pkg/consts/clusterid.go Outdated Show resolved Hide resolved
deployments/liqo/templates/liqo-clusterid-configmap.yaml Show resolved Hide resolved
@giorio94 giorio94 mentioned this pull request Sep 24, 2021
Merged
2 tasks
@aleoli
Copy link
Member Author

aleoli commented Sep 24, 2021

/test

@aleoli
Copy link
Member Author

aleoli commented Sep 24, 2021

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 24, 2021
@adamjensenbot adamjensenbot merged commit 7ccfa79 into master Sep 24, 2021
@adamjensenbot adamjensenbot deleted the aol/clusterid-generation branch September 24, 2021 09:43
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

@palexster palexster palexster approved these changes

@alacuku alacuku Awaiting requested review from alacuku

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleoli @adamjensenbot @palexster @giorio94