Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Python3 support and improves formatting #6

Merged
merged 3 commits into from
Jul 17, 2017

Conversation

JFF-Bohdan
Copy link
Contributor

Fixes issues with Python3 support

  • wrong string encoding/decoding;
  • wrong navigation through dictionaries

Improves formatting and Python3 syntax support:

  • all strings unicode by default, all u" removed;
  • formatting improved using flake8 linter (configuration file added).

Adds conditional import

  • __init__.py now conditionally includes needful files.

Warning! Tests still broken!

http://lucumr.pocoo.org/2014/1/5/unicode-in-2-and-3/

The main difference between Python 2 and Python 3 is the basic types that exist to deal with texts and bytes. On Python 3 we have one text type: str which holds Unicode data and two byte types bytes and bytearray.

! fixes support of Python 3: strings encoding/decoding and dict iterating
  * formatting
  * modern string formatting
+ adds flake8 configuration file and .gitignore
@viplifes viplifes merged commit 3b13c30 into liqpay:master Jul 17, 2017
@viplifes
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants