general changes to support flow file validation (DAT-10588) #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenMassaro
changed the title
wwillard7800
approved these changes
Jun 21, 2022
suryaaki2
added a commit
that referenced
this pull request
Jul 28, 2022
* make base license message public (DAT-10584) (#2941) * make BASE_INVALID_LICENSE_MESSAGE variable private * Added testing framework modifications for flow DAT 10586 (#2981) Co-authored-by: Steven Massaro <steven.massaro.web@gmail.com> * general changes to support flow file validation (DAT-10588) (#2986) add createIfNull(Map) method to CollectionUtil expose separate validate() method in CommandScope add constructor to CommandValidationException(Throwable) * do not allow commands to close the top level output stream * create the UnclosableOutputStream in the setOutput method * Sonar lint cleanup * Moved UnclosableOutputStream class into CommandScope and made it private Do not create if output stream is null DAT-10419 * add liquibase flow and flow.validate goals to maven plugin (DAT-10576) (#3015) Add a flow and flow.validate goal to the maven plugin. Also, add class check before casting in Main.java. * allow passing any arguments to flow commands from maven plugin (DAT-10944) (#3103) Add a flowCommandArguments Map to the mojo definition for flow and flow.validate maven goals. The arguments will be passed to every command that is run in flow. Co-authored-by: Wesley willard <wwillard@austin.rr.com> Co-authored-by: Wesley Willard <wwillard@datical.com> Co-authored-by: suryaaki2 <80348493+suryaaki2@users.noreply.github.com>
wwillard7800
added a commit
that referenced
this pull request
Aug 8, 2022
* make base license message public (DAT-10584) (#2941) * make BASE_INVALID_LICENSE_MESSAGE variable private * Added testing framework modifications for flow DAT 10586 (#2981) Co-authored-by: Steven Massaro <steven.massaro.web@gmail.com> * general changes to support flow file validation (DAT-10588) (#2986) add createIfNull(Map) method to CollectionUtil expose separate validate() method in CommandScope add constructor to CommandValidationException(Throwable) * do not allow commands to close the top level output stream * create the UnclosableOutputStream in the setOutput method * Sonar lint cleanup * Moved UnclosableOutputStream class into CommandScope and made it private Do not create if output stream is null DAT-10419 * add liquibase flow and flow.validate goals to maven plugin (DAT-10576) (#3015) Add a flow and flow.validate goal to the maven plugin. Also, add class check before casting in Main.java. * Handle open of defaults file with new PathHandlerFactory.open method DAT-10444 * allow passing any arguments to flow commands from maven plugin (DAT-10944) (#3103) Add a flowCommandArguments Map to the mojo definition for flow and flow.validate maven goals. The arguments will be passed to every command that is run in flow. * Remove unused line of code DAT-10444 * Fix build issue DAT-10444 * Use different constructor for SearchPathResourceAcessor to avoid using previous searchPath setting DAT-10772 * WIP * Remove unintentionally committed file DAT-10444 Co-authored-by: Steven Massaro <steven.massaro.web@gmail.com> Co-authored-by: suryaaki2 <80348493+suryaaki2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Things to be aware of
Things to worry about
Additional Context