Handle open of defaults file with new Resource API DAT-10444 #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steven Massaro <steven.massaro.web@gmail.com>
add createIfNull(Map) method to CollectionUtil expose separate validate() method in CommandScope add constructor to CommandValidationException(Throwable)
do not allow individual commands to close the top-level OutputStream (System.out)
Do not create if output stream is null DAT-10419
#3015) Add a flow and flow.validate goal to the maven plugin. Also, add class check before casting in Main.java.
…0944) (#3103) Add a flowCommandArguments Map to the mojo definition for flow and flow.validate maven goals. The arguments will be passed to every command that is run in flow.
nvoxland
approved these changes
Jul 29, 2022
nvoxland
reviewed
Jul 29, 2022
| @@ -526,23 +526,25 @@ private List<ConfigurationValueProvider> registerValueProviders(String[] args) t | |||
| } | |||
|
|
|||
| final File defaultsFile = new File(defaultsFileConfig.getValue()); | |||
There was a problem hiding this comment.
Can this line be removed? Seems like it shouldn't be used anymore?
There was a problem hiding this comment.
Thanks, I removed it.
DAT-10444
DAT-10444
previous searchPath setting DAT-10772
wwillard7800
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAT-10444
In order to support the ability to open defaults files that are not on the file system, we use the
PathHandlerFactoryto open the file, rather than directly opening it with the Java API