Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add liquibase flow and flow.validate goals to maven plugin (DAT-10576) #3015

Merged
merged 3 commits into from Jul 13, 2022

Conversation

StevenMassaro
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Add a flow and flow.validate goal to the maven plugin. Also, add class check before casting in Main.java.

Things to be aware of

Not all Liquibase commands will work out of the box when executed through flow and the maven integration.

Things to worry about

See above.

Additional Context

@github-actions
Copy link

github-actions bot commented Jun 28, 2022

Unit Test Results

  4 548 files  ±0    4 548 suites  ±0   32m 25s ⏱️ + 1m 57s
  4 531 tests ±0    4 313 ✔️  - 4     218 💤 +4  0 ±0 
53 664 runs  ±0  48 652 ✔️  - 4  5 012 💤 +4  0 ±0 

Results for commit 496d606. ± Comparison against base commit 44a3c50.

♻️ This comment has been updated with latest results.

@kataggart kataggart added this to To Do in Conditioning++ via automation Jun 30, 2022
Copy link
Contributor

@abrackx abrackx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge freeze 🥶

@StevenMassaro StevenMassaro merged commit 2d6c3b0 into DAT-10419 Jul 13, 2022
Conditioning++ automation moved this from To Do to Done Jul 13, 2022
@StevenMassaro StevenMassaro deleted the DAT-10576 branch July 13, 2022 16:20
suryaaki2 added a commit that referenced this pull request Jul 28, 2022
* make base license message public (DAT-10584) (#2941)

* make BASE_INVALID_LICENSE_MESSAGE variable private

* Added testing framework modifications for flow DAT 10586 (#2981)

Co-authored-by: Steven Massaro <steven.massaro.web@gmail.com>

* general changes to support flow file validation (DAT-10588) (#2986)

add createIfNull(Map) method to CollectionUtil
expose separate validate() method in CommandScope
add constructor to CommandValidationException(Throwable)

* do not allow commands to close the top level output stream

* create the UnclosableOutputStream in the setOutput method

* Sonar lint cleanup

* Moved UnclosableOutputStream class into CommandScope and made it private
Do not create if output stream is null

DAT-10419

* add liquibase flow and flow.validate goals to maven plugin (DAT-10576) (#3015)

Add a flow and flow.validate goal to the maven plugin. Also, add class check before casting in Main.java.

* allow passing any arguments to flow commands from maven plugin (DAT-10944) (#3103)

Add a flowCommandArguments Map to the mojo definition for flow and flow.validate maven goals. The arguments will be passed to every command that is run in flow.

Co-authored-by: Wesley willard <wwillard@austin.rr.com>
Co-authored-by: Wesley Willard <wwillard@datical.com>
Co-authored-by: suryaaki2 <80348493+suryaaki2@users.noreply.github.com>
wwillard7800 added a commit that referenced this pull request Aug 8, 2022
* make base license message public (DAT-10584) (#2941)

* make BASE_INVALID_LICENSE_MESSAGE variable private

* Added testing framework modifications for flow DAT 10586 (#2981)

Co-authored-by: Steven Massaro <steven.massaro.web@gmail.com>

* general changes to support flow file validation (DAT-10588) (#2986)

add createIfNull(Map) method to CollectionUtil
expose separate validate() method in CommandScope
add constructor to CommandValidationException(Throwable)

* do not allow commands to close the top level output stream

* create the UnclosableOutputStream in the setOutput method

* Sonar lint cleanup

* Moved UnclosableOutputStream class into CommandScope and made it private
Do not create if output stream is null

DAT-10419

* add liquibase flow and flow.validate goals to maven plugin (DAT-10576) (#3015)

Add a flow and flow.validate goal to the maven plugin. Also, add class check before casting in Main.java.

* Handle open of defaults file with new PathHandlerFactory.open method

DAT-10444

* allow passing any arguments to flow commands from maven plugin (DAT-10944) (#3103)

Add a flowCommandArguments Map to the mojo definition for flow and flow.validate maven goals. The arguments will be passed to every command that is run in flow.

* Remove unused line of code

DAT-10444

* Fix build issue

DAT-10444

* Use different constructor for SearchPathResourceAcessor to avoid using
previous searchPath setting

DAT-10772

* WIP

* Remove unintentionally committed file DAT-10444

Co-authored-by: Steven Massaro <steven.massaro.web@gmail.com>
Co-authored-by: suryaaki2 <80348493+suryaaki2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants